Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-color-palette/#28 #29

Merged
merged 1 commit into from
Feb 19, 2024
Merged

create-color-palette/#28 #29

merged 1 commit into from
Feb 19, 2024

Conversation

gahyuun
Copy link
Member

@gahyuun gahyuun commented Feb 19, 2024

πŸ“Œ μž‘μ—… λ‚΄μš©

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • color palette 생성

ν”Όκ·Έλ§ˆμ—λ„ 색 μ •μ˜ν•΄λ†“μ•˜μŠ΅λ‹ˆλ‹€! ν”Όκ·Έλ§ˆλ‘œ ν™•μΈν•˜μ‹œλŠ” 게 νŽΈν•  것 κ°™μ•„μš”

@gahyuun gahyuun self-assigned this Feb 19, 2024
@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-xqzyzncrtm.chromatic.com/

seonghunYang
seonghunYang approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@seonghunYang seonghunYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€.
  • ν¬λ‘œλ§ˆν‹±κ³Ό μŠ€ν† λ¦¬λΆμ„ ν™•μΈν–ˆμ„ λ•Œ, secondary의 border 색상이 많이 흐렀진 것 κ°™μŠ΅λ‹ˆλ‹€. μ˜λ„ν•˜μ‹  λ³€κ²½μ‚¬ν•­μΈκ°€μš”?
  • 이 사항에 λ¬Έμ œκ°€ μ—†λ‹€λ©΄ 병합해도 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€!

@gahyuun
Copy link
Member Author

gahyuun commented Feb 19, 2024

  • μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€.
  • ν¬λ‘œλ§ˆν‹±κ³Ό μŠ€ν† λ¦¬λΆμ„ ν™•μΈν–ˆμ„ λ•Œ, secondary의 border 색상이 많이 흐렀진 것 κ°™μŠ΅λ‹ˆλ‹€. μ˜λ„ν•˜μ‹  λ³€κ²½μ‚¬ν•­μΈκ°€μš”?
  • 이 사항에 λ¬Έμ œκ°€ μ—†λ‹€λ©΄ 병합해도 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€!

color paletteκ°€ λ³€κ²½λ˜λ©΄μ„œ secondary의 border 색상이 λ³€κ²½λœ 것 κ°™μŠ΅λ‹ˆλ‹€
list component도 color palette에 맞좰 변경이 ν•„μš”ν•  것 κ°™μ•„μ„œ ν•΄λ‹Ή λΈŒλžœμΉ˜κ°€ λ¨Έμ§€λ˜λ©΄ list componentλž‘ 같이 μˆ˜μ •ν•˜κ² μŠ΅λ‹ˆλ‹€!

yougyung
yougyung approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@yougyung yougyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€ !

@gahyuun gahyuun merged commit 249d1af into main Feb 19, 2024
3 checks passed
@gahyuun gahyuun deleted the create-color-palette/#28 branch February 19, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yougyung yougyung yougyung approved these changes

@seonghunYang seonghunYang seonghunYang approved these changes

Assignees

@gahyuun gahyuun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gahyuun @seonghunYang @yougyung