Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive Result UI/#96 #101

Merged
merged 10 commits into from
May 15, 2024
Merged

responsive Result UI/#96 #101

merged 10 commits into from
May 15, 2024

Conversation

yougyung
Copy link
Member

@yougyung yougyung commented May 10, 2024

πŸ“Œ μž‘μ—… λ‚΄μš©

2024-05-10.12.37.13.mov

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • result page λ°˜μ‘ν˜• μž‘μ—…
  • result page dialogμ—΄λ¦ΌμƒνƒœμΈ detail page λ°˜μ‘ν˜• μž‘μ—…

πŸ€” κ³ λ―Ό ν–ˆλ˜ λΆ€λΆ„

  • Button에 λ°˜μ‘ν˜•μ„ μΆ”κ°€ν•˜κΈ° μœ„ν•΄μ„œ className속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • κ°œλ°œμ„ 진행할 λ•ŒλŠ” 기이수/미이수 κ³Όλͺ©μ— λŒ€ν•œ μƒνƒœ κ°’ μ €μž₯이 λ”°λ‘œ λΆˆν•„μš”ν•˜λ‹€κ³  μƒκ°ν•˜μ—¬ μ§„ν–‰ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€. κ²°κ³Ό ν™”λ©΄ 곡유λ₯Ό μœ„ν•΄μ„œ testμ˜μƒμ„ μ°λ‹€λ³΄λ‹ˆ, 기이수/미이수 κ³Όλͺ©μ— λŒ€ν•œ μƒνƒœ 값을 μ €μž₯ν•  ν•„μš”κ°€ λŠκ»΄μ§€λ„€μš”. λ‹€μŒ μŠ€ν”„λ¦°νŠΈμ— μΆ”κ°€ν•˜λ„λ‘ ν•˜κ² μŠ΅λ‹ˆλ‹€.

@yougyung yougyung self-assigned this May 10, 2024
@yougyung yougyung requested a review from seonghunYang as a code owner May 10, 2024 03:38
@yougyung yougyung linked an issue May 10, 2024 that may be closed by this pull request
@yougyung yougyung requested a review from gahyuun as a code owner May 10, 2024 03:38
Copy link

Copy link

@@ -30,13 +32,26 @@ const displaySeveralMajor = (category: ResultCategoryKey) => {
const { DUAL_MANDATORY_MAJOR, DUAL_ELECTIVE_MAJOR, DUAL_BASIC_ACADEMICAL_CULTURE, SUB_MAJOR } = RESULT_CATEGORY;
const { DUAL, SUB } = MAJOR_NOTATION;

function render(majorType: string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • render ν•¨μˆ˜μ˜ 이름을 μ–΄λ–€ 것을 λ Œλ”λ§ν•˜λŠ”μ§€ 더 λͺ…ν™•ν•˜κ²Œ ν•˜λŠ” 것이 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +16 to +20
width={1200}
height={270}
alt="category-fullfill-image"
className={cn('min-h-20 max-h-40', 'md:min-h-32')}
/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Image μ»΄ν¬λ„ŒνŠΈμ— height 속성과 className으둜 height λͺ¨λ‘ μ§€μ •ν•˜λ©΄ μ–΄λ–»κ²Œ μ μš©λ˜λŠ”μ§€ κΆκΈˆν•˜λ„€μš”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ΅¬ν˜„ν™”λ©΄μ—μ„œλŠ” className값을 λ”°λ₯΄λŠ” κ²ƒμœΌλ‘œ ν™•μΈλ˜μ—ˆμŠ΅λ‹ˆλ‹€ :)

Copy link

Copy link
Member

@gahyuun gahyuun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€ ν˜Ήμ‹œ label에 κ΄€ν•΄μ„œλŠ” λ°˜μ‘ν˜• μ§„ν–‰ν•˜μ‹€ 의ν–₯ μžˆμœΌμ‹ μ§€ κΆκΈˆν•©λ‹ˆλ‹€!

@yougyung
Copy link
Member Author

yougyung commented May 11, 2024

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€ ν˜Ήμ‹œ label에 κ΄€ν•΄μ„œλŠ” λ°˜μ‘ν˜• μ§„ν–‰ν•˜μ‹€ 의ν–₯ μžˆμœΌμ‹ μ§€ κΆκΈˆν•©λ‹ˆλ‹€!

곡톡 μ»΄ν¬λ„ŒνŠΈμΈ 만큼 λ‹€λ₯Έ κ³³μ—μ„œ μ–΄λ–»κ²Œ μ μš©λ μ§€ μ‘°μ‹¬μŠ€λŸ¬μ›Œ λ°˜μ‘ν˜•μ„ μ§„ν–‰ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€. 곡톡 μ»΄ν¬λ„ŒνŠΈμ˜ λ°˜μ‘ν˜•μ— λŒ€ν•΄μ„œλŠ” ν”„λ‘œμ νŠΈ μ „λ°˜μ˜ λ°˜μ‘ν˜• μž‘μ—…μ΄ μ§„ν–‰λœ μ‹œμ μ— μž‘μ—…ν•˜λŠ” 것이 μ μ ˆν•˜μ§€μ•Šμ„κΉŒ 생각이 λ“­λ‹ˆλ‹€

Copy link

@yougyung yougyung merged commit 514dfc3 into main May 15, 2024
2 of 3 checks passed
@yougyung yougyung deleted the result-ui/#96 branch May 15, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[#55] UI μˆ˜μ •
3 participants