Merge pull request #21 from MyUnisoft/platform

refactor: remove node installation in Dockerfile
MyUnisoft · Aug 13, 2024 · 2c167f9 · 2c167f9
2 parents d2778ea + a682814
commit 2c167f9
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 7 deletions.
diff --git a/.github/workflows/build-lib-c-binaries.yml b/.github/workflows/build-lib-c-binaries.yml
@@ -96,7 +96,7 @@ jobs:
         tar -czf ${{ matrix.platform }}.tar.gz *
 
     - name: Upload artifact
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v3
       with:
         name: binaries
         path: ./binaries/${{ matrix.platform }}.tar.gz
diff --git a/LIBHEIF_VERSION b/LIBHEIF_VERSION
diff --git a/platform/linux-x64/Dockerfile b/platform/linux-x64/Dockerfile
@@ -18,9 +18,6 @@ RUN apt-get update && \
     python3-mako \
     && rm -rf /var/lib/apt/lists/*
 
-RUN curl -sL https://deb.nodesource.com/setup_20.x | bash - && \
-    apt-get install -y nodejs
-
 RUN git clone https://github.com/microsoft/vcpkg.git && \
     ./vcpkg/bootstrap-vcpkg.sh && \
     ./vcpkg/vcpkg install libheif
diff --git a/platform/win32-ia32/Dockerfile b/platform/win32-ia32/Dockerfile
@@ -6,7 +6,6 @@ RUN powershell -NoProfile -ExecutionPolicy Bypass -Command \
     [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; \
     iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))"
 
-RUN choco install -y nodejs --version=20.9.0 --x86
 RUN choco install -y git visualstudio2019buildtools visualstudio2019-workload-vctools
 RUN choco install -y python3
 

diff --git a/platform/win32-x64/Dockerfile b/platform/win32-x64/Dockerfile
@@ -6,7 +6,6 @@ RUN powershell -NoProfile -ExecutionPolicy Bypass -Command \
     [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; \
     iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))"
 
-RUN choco install -y nodejs --version=20.9.0
 RUN choco install -y git visualstudio2019buildtools visualstudio2019-workload-vctools
 RUN choco install -y python3