Fix failing tests (#1482)

* cron schedule * jenkins description during run * jenkins description during run * jenkins description during run * cron modify * interval between jobs * modify time * fix language code * fix TestAccGenesysCloudOAuthResourceCredential test * fix message integration tests * fix failing tests * fix failures * fix testcases
MyPureCloud · Jan 17, 2025 · eeb946a · eeb946a
1 parent ff98146
commit eeb946a
Show file tree

Hide file tree

Showing 8 changed files with 34 additions and 9 deletions.
diff --git a/...egrations_open/data_source_genesyscloud_conversations_messaging_integrations_open_test.go b/...egrations_open/data_source_genesyscloud_conversations_messaging_integrations_open_test.go
@@ -3,6 +3,7 @@ package conversations_messaging_integrations_open
 import (
 	"fmt"
 	"testing"
+	"time"
 
 	cmMessagingSetting "terraform-provider-genesyscloud/genesyscloud/conversations_messaging_settings"
 	cmSupportedContent "terraform-provider-genesyscloud/genesyscloud/conversations_messaging_supportedcontent"
@@ -11,14 +12,14 @@ import (
 
 	"github.com/google/uuid"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 )
 
 /*
 Test Class for the conversations messaging integrations open Data Source
 */
 
 func TestAccDataSourceConversationsMessagingIntegrationsOpen(t *testing.T) {
-	t.Parallel()
 	var (
 		dataSourceLabel                                 = "data_test_messaging_open"
 		resourceLabel                                   = "test_messaging_open"
@@ -70,9 +71,17 @@ func TestAccDataSourceConversationsMessagingIntegrationsOpen(t *testing.T) {
 				),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttrPair("data.genesyscloud_conversations_messaging_integrations_open."+dataSourceLabel, "id", "genesyscloud_conversations_messaging_integrations_open."+resourceLabel, "id"),
+					func(s *terraform.State) error {
+						time.Sleep(30 * time.Second) // Wait for 30 seconds for proper updation
+						return nil
+					},
 				),
 			},
 		},
+		CheckDestroy: func(state *terraform.State) error {
+			time.Sleep(60 * time.Second)
+			return testVerifyConversationsMessagingIntegrationsOpenDestroyed(state)
+		},
 	})
 }
 

diff --git a/...integrations_open/resource_genesyscloud_conversations_messaging_integrations_open_test.go b/...integrations_open/resource_genesyscloud_conversations_messaging_integrations_open_test.go
@@ -3,6 +3,7 @@ package conversations_messaging_integrations_open
 import (
 	"fmt"
 	"testing"
+	"time"
 
 	"github.com/google/uuid"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
@@ -23,7 +24,6 @@ tests for conversations_messaging_integrations_open.
 */
 
 func TestAccResourceConversationsMessagingIntegrationsOpen(t *testing.T) {
-	t.Parallel()
 	var (
 		resourceLabel                                   = "test_messaging_open"
 		name                                            = "Terraform Integrations Messaging Open " + uuid.NewString()
@@ -85,9 +85,18 @@ func TestAccResourceConversationsMessagingIntegrationsOpen(t *testing.T) {
 				ImportState:             true,
 				ImportStateVerify:       true,
 				ImportStateVerifyIgnore: []string{"outbound_notification_webhook_signature_secret_token"},
+				Check: resource.ComposeTestCheckFunc(
+					func(s *terraform.State) error {
+						time.Sleep(30 * time.Second) // Wait for 30 seconds for proper updation
+						return nil
+					},
+				),
 			},
 		},
-		CheckDestroy: testVerifyConversationsMessagingIntegrationsOpenDestroyed,
+		CheckDestroy: func(state *terraform.State) error {
+			time.Sleep(60 * time.Second)
+			return testVerifyConversationsMessagingIntegrationsOpenDestroyed(state)
+		},
 	})
 }
 

diff --git a/genesyscloud/integration_credential/resource_genesyscloud_integration_credential_test.go b/genesyscloud/integration_credential/resource_genesyscloud_integration_credential_test.go
@@ -282,7 +282,7 @@ func generateGenesysOauthCredentialResource(resourceLabel string, name string) s
 
 	return fmt.Sprintf(`
       data "genesyscloud_auth_role" "admin" {
-		name = "Admin"
+		name = "admin"
 	  }
 
       resource "genesyscloud_oauth_client" "%s" {

diff --git a/...ional_group_routing/resource_genesyscloud_routing_queue_conditional_group_routing_test.go b/...ional_group_routing/resource_genesyscloud_routing_queue_conditional_group_routing_test.go
@@ -263,7 +263,6 @@ func TestAccResourceRoutingQueueConditionalGroupRouting(t *testing.T) {
 						return nil
 					},
 				),
-				PreventPostDestroyRefresh: true,
 			},
 			{
 				// Import/Read
@@ -274,7 +273,7 @@ func TestAccResourceRoutingQueueConditionalGroupRouting(t *testing.T) {
 			},
 		},
 		CheckDestroy: func(state *terraform.State) error {
-			time.Sleep(40 * time.Second)
+			time.Sleep(60 * time.Second)
 			return testVerifyGroupsAndUsersDestroyed(state)
 		},
 	})

diff --git a/...ny_providers_edges_phone/data_source_genesyscloud_telephony_providers_edges_phone_test.go b/...ny_providers_edges_phone/data_source_genesyscloud_telephony_providers_edges_phone_test.go
@@ -9,13 +9,13 @@ import (
 	"terraform-provider-genesyscloud/genesyscloud/user"
 	"terraform-provider-genesyscloud/genesyscloud/util"
 	"testing"
+	"time"
 
 	"github.com/google/uuid"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
 func TestAccDataSourcePhone(t *testing.T) {
-	t.Parallel()
 	var (
 		phoneResourceLabel     = "phone1234"
 		phoneDataResourceLabel = "phoneData"
@@ -43,6 +43,9 @@ func TestAccDataSourcePhone(t *testing.T) {
 		ProviderFactories: provider.GetProviderFactories(providerResources, providerDataSources),
 		Steps: []resource.TestStep{
 			{
+				PreConfig: func() {
+					time.Sleep(30 * time.Second)
+				},
 				Config: user.GenerateUserResource(
 					userResourceLabel1,
 					userEmail1,

diff --git a/...phony_providers_edges_phone/resource_genesyscloud_telephony_providers_edges_phone_test.go b/...phony_providers_edges_phone/resource_genesyscloud_telephony_providers_edges_phone_test.go
@@ -143,6 +143,9 @@ func TestAccResourcePhoneBasic(t *testing.T) {
 		ProviderFactories: provider.GetProviderFactories(providerResources, providerDataSources),
 		Steps: []resource.TestStep{
 			{
+				PreConfig: func() {
+					time.Sleep(30 * time.Second)
+				},
 				Config: config1,
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("genesyscloud_telephony_providers_edges_phone."+phoneResourceLabel, "name", name1),

diff --git a/...lephony_providers_edges_site/resource_genesyscloud_telephony_providers_edges_site_test.go b/...lephony_providers_edges_site/resource_genesyscloud_telephony_providers_edges_site_test.go
@@ -23,7 +23,6 @@ import (
 )
 
 func TestAccResourceSite(t *testing.T) {
-	t.Parallel()
 
 	var (
 		// site

diff --git a/genesyscloud/user/resource_genesyscloud_user_test.go b/genesyscloud/user/resource_genesyscloud_user_test.go
@@ -1132,7 +1132,10 @@ func TestAccResourceUserRestore(t *testing.T) {
 				),
 			},
 		},
-		CheckDestroy: testVerifyUsersDestroyed,
+		CheckDestroy: func(state *terraform.State) error {
+			time.Sleep(45 * time.Second)
+			return testVerifyUsersDestroyed(state)
+		},
 	})
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,7 +23,6 @@ import ( @@
     )
     func TestAccResourceSite(t *testing.T) {
-    	t.Parallel()
     	var (
     		// site
@@ Expand Down @@