Feat/social links controller unit tests#1336
Merged
aji70 merged 2 commits intoJun 30, 2026
Merged
Conversation
Rewrites social-links.controller.spec.ts from 7 thin smoke tests to 36 focused unit tests covering the full SocialLinkController surface. New coverage added (all service calls are mocked): - guard & throttle metadata: ThrottlerGuard on class, limit/ttl on create and update, verified absence of @Throttle on the read-only list endpoint - Swagger metadata: @apitags on class, @apioperation on every handler, @apiresponse(200) on list and @apiresponse(404) on update - list: return value pass-through, single service call, exact arg forwarding, error propagation - create: happy path, all fields, partial dto, null-clear, return value pass-through, BadRequestException and generic Error propagation - update: happy path, uuid id forwarding, partial update, null-clear, return value pass-through, BadRequestException, NotFoundException, and generic Error propagation - service isolation: each endpoint only calls its own service method Closes MyFanss#1054 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@marvs8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test Plan
Automated tests added or updated
backend/src/**/*.spec.ts) — service/guard/decorator logic in isolationbackend/test/**/*.e2e-spec.ts) — HTTP round-trips with mocked infrastructurefrontend/src/**/*.test.{ts,tsx}) — React component behaviourfrontend/e2e/**/*.spec.ts) — Playwright browser flowscontract/) — Soroban/Rust unit tests viacargo testHow to run the tests locally
Manual verification checklist
cd backend && npm run lint/cd frontend && npm run lintRelated issues
Notes for reviewers
closes #1054