fix: repair diagnostic page guard

[kunal-9090]

Summary

• remove stale conflict text from the diagnostic page
• use the server Supabase helper instead of an undefined client helper
• keep diagnostics behind ENABLE_DIAGNOSTIC_PAGE outside production

Testing

• git diff --check
• npm run lint -- --file app/diagnostic/page.tsx (blocked locally: dependencies are not installed, next command is missing)

Summary by CodeRabbit

• Bug Fixes
  • Improved access handling for the diagnostics page so it is only available when diagnostics are enabled, with a proper not-found response when it’s disabled.
  • Stabilized diagnostic data loading to reduce issues when checking database-related status information.

[netlify]

👷 Deploy request for docmagic1 pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	b90687c

[netlify]

👷 Deploy request for docmagic-muneer pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	b90687c

[vercel]

@kunal-9090 is attempting to deploy a commit to the muneerali199's projects Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 199b2618-07f8-42a8-aaea-8308813668a0

📥 Commits

Reviewing files that changed from the base of the PR and between 7f5e22a and b90687c.

📒 Files selected for processing (1)

• app/diagnostic/page.tsx

---

📝 Walkthrough

Walkthrough

Removed the production-only "Access Denied" guard from the diagnostic page, leaving diagnosticsEnabled checks and notFound() as the sole access control. Changed Supabase client initialization to use an awaited server-side creator (await createServer()) before executing the database query.

Changes

Diagnostic Page Access Guard

Layer / File(s)	Summary
Simplify access guard and await Supabase init app/diagnostic/page.tsx	Removes the redundant production-only Access Denied early return, leaving diagnosticsEnabled + notFound() as the access control, and switches Supabase client creation to await createServer() before querying the subscription_plans table.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• Muneerali199/Draftdeckai#594: Both PRs modify the same access guard and Supabase-init flow in app/diagnostic/page.tsx.

Suggested labels: bug, type:security, level:intermediate

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is missing several required template sections, including the issue reference, change type, dependencies, screenshots, and checklist.	Add the missing template sections, especially Fixes #, Type of change, Changes Made, Dependencies, screenshots if relevant, and the checklist.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: fixing the diagnostic page guard.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}