Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add todo app to the list #1500

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

pixelledbot
Copy link

No description provided.

},
{
"name": "Todo List App",
"link": "https://github.com/pixelledbot/todo-list-app",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"link": "https://github.com/pixelledbot/todo-list-app",
"link": "https://github.com/pixelledbot/to-do-list",

Did you mean this?

Otherwise, check if your repository is private, that may be causing the issue of the link being broken.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I meant that

{
"name": "Todo List App",
"link": "https://github.com/pixelledbot/todo-list-app",
"label": "good-first-issue",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"label": "good-first-issue",
"label": "good first issue",

Most projects use good first issue without the dashes. If that is the case with this entry, please commit this suggested change.

data.json Outdated
Comment on lines 2219 to 2221

]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
]

Please clean up these unneeded blank lines

Copy link
Collaborator

@sammyhori sammyhori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the entry. Unfortunately the link provided doesn't seem to go anywhere, is the repository private?
Otherwise, I did notice you had a similar javascript project that you may've been trying to link to. I have suggested a change to that above, but feel free to ignore that if I'm wrong.

Just to warn you too, currently, that repository is not valid due to a lack of any appropriately tagged issues too, so it still wouldn't be accepted in it's current state if the link was changed to that.

Thanks a lot,
Sammy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants