-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add todo app to the list #1500
base: main
Are you sure you want to change the base?
Add todo app to the list #1500
Conversation
}, | ||
{ | ||
"name": "Todo List App", | ||
"link": "https://github.com/pixelledbot/todo-list-app", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"link": "https://github.com/pixelledbot/todo-list-app", | |
"link": "https://github.com/pixelledbot/to-do-list", |
Did you mean this?
Otherwise, check if your repository is private, that may be causing the issue of the link being broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I meant that
{ | ||
"name": "Todo List App", | ||
"link": "https://github.com/pixelledbot/todo-list-app", | ||
"label": "good-first-issue", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"label": "good-first-issue", | |
"label": "good first issue", |
Most projects use good first issue
without the dashes. If that is the case with this entry, please commit this suggested change.
data.json
Outdated
|
||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
] | |
] |
Please clean up these unneeded blank lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the entry. Unfortunately the link provided doesn't seem to go anywhere, is the repository private?
Otherwise, I did notice you had a similar javascript project that you may've been trying to link to. I have suggested a change to that above, but feel free to ignore that if I'm wrong.
Just to warn you too, currently, that repository is not valid due to a lack of any appropriately tagged issues too, so it still wouldn't be accepted in it's current state if the link was changed to that.
Thanks a lot,
Sammy :)
No description provided.