Repository navigation
Print the quarantined, action-level and expect report tables whole - #1706
Merged
Merged
Conversation
…672) The dispositions summary prints at its full width (#1661), but the --quarantined table, the action-level table and the expect report per-rule table still went through console.print(table), so Rich fitted them to the terminal and cut cells with an ellipsis. On 80 columns a record ID cut to a1b2… could not be copied into a retry, and a rule id read never_matc…. The full-width print moves to renderers/whole_table.print_whole and all four tables use it. Closes #1672 Signed-off-by: Muizz Lateef <Lateefmuizz@gmail.com>
…es-whole-on-main Signed-off-by: Muizz Lateef <Lateefmuizz@gmail.com> # Conflicts: # agent_actions/cli/_MANIFEST.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1672 (already closed). Replaces #1692, which was stacked on the open #1663→#1675 stack. This is the same change rebuilt on main, so it can merge now.
Problem
The dispositions summary prints at its full width (#1661). The
--quarantinedtable, the action-level table and theagac expect reportper-rule table still usedconsole.print(table), so Rich fitted them to the terminal and cut cells with an ellipsis. On 80 columns a record ID cut toa1b2…cannot be copied into a retry, and a rule id readsnever_matc….Change
DispositionsCommand._print_wholemoves tocli/renderers/whole_table.print_whole(console, table).cliandcli/renderersupdated.Verification
tests/unit/cli/test_tables_print_whole_on_a_narrow_terminal.pyrenders each table at 80 columns and asserts the full record ID, action name, rule ids and types, with no….tests/unit/cli430 passed; ruff and mypy clean.