remove debug highlight

MrWangJustToDo · Aug 30, 2024 · 3830ae6 · 3830ae6
1 parent 440ddc3
commit 3830ae6
Show file tree

Hide file tree

Showing 9 changed files with 41 additions and 285 deletions.
diff --git a/packages/myreact-dom/src/client/index.ts b/packages/myreact-dom/src/client/index.ts
@@ -10,7 +10,6 @@ import {
   enableDOMField,
   enableEventSystem,
   enableEventTrack,
-  enableHighlight,
   injectDevField,
 } from "../shared";
 
@@ -48,7 +47,6 @@ const __my_react_dom_shared__ = {
   enableDOMField,
   enableEventSystem,
   enableEventTrack,
-  enableHighlight,
 };
 
 const __my_react_dom_internal__ = {

diff --git a/packages/myreact-dom/src/client/renderDispatch/instance.ts b/packages/myreact-dom/src/client/renderDispatch/instance.ts
@@ -4,7 +4,6 @@ import { CustomRenderDispatch, NODE_TYPE, initHMR, listenerMap, safeCall, unmoun
 import { append, clearNode, create, position, update } from "@my-react-dom-client/api";
 import { clientDispatchMount } from "@my-react-dom-client/dispatchMount";
 import { render } from "@my-react-dom-client/mount";
-import { highlightAppendFiber, highlightRefFiber, highlightUpdateFiber } from "@my-react-dom-client/tools";
 import { latestNoopRender, legacyNoopRender } from "@my-react-dom-noop/mount";
 import {
   asyncUpdateTimeLimit,
@@ -244,19 +243,6 @@ function hmrRemount(this: ClientDomDispatch, cb?: () => void) {
 }
 
 if (__DEV__) {
-  // dev highlight
-  Object.defineProperty(ClientDomDispatch.prototype, "patchToCommitUpdate", {
-    value: highlightUpdateFiber,
-  });
-
-  Object.defineProperty(ClientDomDispatch.prototype, "patchToCommitAppend", {
-    value: highlightAppendFiber,
-  });
-
-  Object.defineProperty(ClientDomDispatch.prototype, "patchToCommitSetRef", {
-    value: highlightRefFiber,
-  });
-
   // dev log tree
   Object.defineProperty(ClientDomDispatch.prototype, "_debugRender", {
     get: function (this: ClientDomDispatch) {

diff --git a/packages/myreact-dom/src/client/tools/highlight.ts b/packages/myreact-dom/src/client/tools/highlight.ts
diff --git a/packages/myreact-dom/src/client/tools/index.ts b/packages/myreact-dom/src/client/tools/index.ts
@@ -1,5 +1,4 @@
 export * from "./createPortal";
 export * from "./findDOMNode";
 export * from "./hmr";
-export * from "./highlight";
 export * from "./unmountComponentAtNode";
diff --git a/packages/myreact-dom/src/shared/debug.ts b/packages/myreact-dom/src/shared/debug.ts
@@ -12,12 +12,11 @@ import {
 import { include } from "@my-react/react-shared";
 
 import { ClientDomDispatch } from "@my-react-dom-client/renderDispatch";
-import { HighLight, debounce } from "@my-react-dom-client/tools";
 import { latestNoopRender, legacyNoopRender } from "@my-react-dom-noop/mount/render";
 import { PlainElement, ContainerElement, CommentStartElement } from "@my-react-dom-server/api";
 
-import { enableControlComponent, enableDOMField, enableEventSystem, enableEventTrack, enableHighlight, enableHighlightWarn, isServer } from "./env";
-import { getFiberWithNativeDom } from "./getFiberWithDom";
+import { enableControlComponent, enableDOMField, enableEventSystem, enableEventTrack, isServer } from "./env";
+import { debounce } from "./tools";
 
 import type { LikeJSX } from "@my-react/react";
 import type { CustomRenderDispatch, MyReactFiberNodeDev } from "@my-react/react-reconciler";
@@ -32,7 +31,6 @@ const __my_react_dom_shared__ = {
   enableDOMField,
   enableEventSystem,
   enableEventTrack,
-  enableHighlight,
 };
 
 const __my_react_dom_internal__ = {
@@ -56,11 +54,6 @@ export const log = (fiber: MyReactFiberNode, level: "warn" | "error", ...rest: a
       devErrorWithFiber(fiber, `[@my-react/react-dom]`, ...rest);
     }
 
-    if (enableHighlightWarn.current && !isServer) {
-      const _fiber = getFiberWithNativeDom(fiber, (f) => f.parent);
-      _fiber && HighLight.getHighLightInstance().highLight(_fiber, "warn");
-    }
-
     enableOptimizeTreeLog.current = last;
 
     return;
@@ -85,11 +78,6 @@ export const logOnce = (fiber: MyReactFiberNode, level: "warn" | "error", key: s
       onceErrorWithKeyAndFiber(fiber, key, `[@my-react/react-dom]`, ...rest);
     }
 
-    if (enableHighlightWarn.current && !isServer) {
-      const _fiber = getFiberWithNativeDom(fiber, (f) => f.parent);
-
-      _fiber && HighLight.getHighLightInstance().highLight(_fiber, "warn");
-    }
     return;
   }
 

diff --git a/packages/myreact-dom/src/shared/env.ts b/packages/myreact-dom/src/shared/env.ts
@@ -23,11 +23,6 @@ export const enableControlComponent = createReadonlyRef(true);
  */
 export const enableEventSystem = createReadonlyRef(true);
 
-/**
- * @internal
- */
-export const enableHighlight = createRef(false);
-
 /**
  * @internal
  */
@@ -48,11 +43,6 @@ export const enableEventTrack = createRef(false);
  */
 export const enableHydrateWarn = createRef(true);
 
-/**
- * @internal
- */
-export const enableHighlightWarn = createRef(false);
-
 /**
  * @internal
  */

diff --git a/packages/myreact-dom/src/shared/tools.ts b/packages/myreact-dom/src/shared/tools.ts
@@ -76,3 +76,17 @@ export const generateGetRawAttrKey = (map: string) => {
     return false;
   };
 };
+
+/**
+ * @internal
+ */
+// eslint-disable-next-line @typescript-eslint/ban-types
+export const debounce = <T extends Function>(callback: T, time?: number): T => {
+  let id = null;
+  return ((...args) => {
+    clearTimeout(id);
+    id = setTimeout(() => {
+      callback.call(null, ...args);
+    }, time || 40);
+  }) as unknown as T;
+};