Skip to content

Commit

Permalink
PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotif…
Browse files Browse the repository at this point in the history
…yEvent

PcatRealTimeClockRuntimeDxe seems to have copied the interface name
LibRtcVirtualNotifyEvent() from EmbeddedPkg's RealTimeClockLib class.
That's not right, for two reasons:

- PcatRealTimeClockRuntimeDxe doesn't consume "EmbeddedPkg.dec" in the
  first place,

- in EmbeddedPkg, the RealTimeClockLib class API
  LibRtcVirtualNotifyEvent() is about to be eliminated (it's a bogus API).

Rename the LibRtcVirtualNotifyEvent() function to VirtualNotifyEvent(),
and make it static.

Tested with booting OVMF.

Cc: Ray Ni <[email protected]>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
Signed-off-by: Laszlo Ersek <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Sami Mujawar <[email protected]>
Tested-by: Sami Mujawar <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
  • Loading branch information
Laszlo Ersek authored and mergify[bot] committed Oct 18, 2023
1 parent 747a08e commit c62fb45
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,10 @@ PcRtcEfiSetWakeupTime (
@param[in] Event The Event that is being processed
@param[in] Context Event Context
**/
STATIC
VOID
EFIAPI
LibRtcVirtualNotifyEvent (
VirtualNotifyEvent (
IN EFI_EVENT Event,
IN VOID *Context
)
Expand Down Expand Up @@ -220,7 +221,7 @@ InitializePcRtc (
Status = gBS->CreateEventEx (
EVT_NOTIFY_SIGNAL,
TPL_NOTIFY,
LibRtcVirtualNotifyEvent,
VirtualNotifyEvent,
NULL,
&gEfiEventVirtualAddressChangeGuid,
&mVirtualAddrChangeEvent
Expand Down

0 comments on commit c62fb45

Please sign in to comment.