test(gestalt-module): tests for DependencyInfo.versionPredicate #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keturn
added
v7
Topic: Module
skaldarnar
approved these changes
May 4, 2021
| assertTrue(predicate.test(nextMinorVersion), "failed to match the next minor version"); | ||
| assertTrue(predicate.test(new Version(nextMinorVersion + "-SNAPSHOT")), "failed to match the next minor snapshot"); | ||
|
|
||
| assertFalse(predicate.test(new Version("1.4.6")), "inappropriately matched an earlier patch version"); |
There was a problem hiding this comment.
Should we add a test to ensure that a snapshot of a non-snapshot version is not matched? Probably same for the test case above.
Suggested change
| assertFalse(predicate.test(new Version("1.4.6")), "inappropriately matched an earlier patch version"); | |
| assertFalse(predicate.test(new Version("1.4.7-SNAPSHOT")), "inappropriately matched same version snapshot"); |
There was a problem hiding this comment.
will be addressed in PR for #113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intended to be included with #101 but it fell off the truck somewhere.