Skip to content

fix: remove fictional SessionFileCache docs and rewrite Future Improvements#545

Open
Catrya wants to merge 1 commit intomainfrom
docs-media-encrypted-chat
Open

fix: remove fictional SessionFileCache docs and rewrite Future Improvements#545
Catrya wants to merge 1 commit intomainfrom
docs-media-encrypted-chat

Conversation

@Catrya
Copy link
Member

@Catrya Catrya commented Mar 24, 2026

  • Remove TODO section claiming SessionFileCache was developed but not yet integrated (never existed)
  • Remove PersistentImageCache proposal that would write decrypted bytes to disk with misleading .enc extension
  • Remove 5 other speculative code snippets (Nostr auth, compression options, multi-select, video support, gallery view)
  • Replace with honest persistent caching principle cache encrypted blobs, decrypt only at display time
  • Add download progress indication as concrete future improvement
  • Remove false Next Steps claiming persistent cache was already implemented
  • Keep conclusion with accurate current status

Summary by CodeRabbit

  • Documentation
    • Updated supported file types: images limited to JPEG/PNG, videos to MP4/MOV/AVI, documents to DOCX with macro blocking enforced.
    • Clarified file validation via MIME detection and image sanitization (EXIF/metadata removal).
    • Revised roadmap: persistent encrypted blob caching and download progress indication highlighted as future improvements.

…ements

  - Remove TODO section claiming SessionFileCache was developed but not yet integrated (never existed)
  - Remove PersistentImageCache proposal that would write decrypted bytes to disk with misleading .enc extension
  - Remove 5 other speculative code snippets (Nostr auth, compression options, multi-select, video support, gallery view)
  - Replace with honest persistent caching principle cache encrypted blobs, decrypt only at display time
  - Add download progress indication as concrete future improvement
  - Remove false Next Steps claiming persistent cache was already implemented
  - Keep conclusion with accurate current status
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1f1c3a88-bd60-41a7-9f1b-60ef2907365e

📥 Commits

Reviewing files that changed from the base of the PR and between e3370f5 and 1e2112f.

📒 Files selected for processing (1)
  • docs/architecture/ENCRYPTED_IMAGE_MESSAGING_IMPLEMENTATION.md

Walkthrough

Documentation updates to encrypted image messaging implementation specify narrowed file type support (JPEG/PNG images, MP4/MOV/AVI videos, DOCX documents), remove a detailed persistent caching TODO, and refocus Future Improvements on disk-based encrypted blob caching and download progress indication.

Changes

Cohort / File(s) Summary
Documentation Update
docs/architecture/ENCRYPTED_IMAGE_MESSAGING_IMPLEMENTATION.md
Narrowed supported file types (removed GIF/WEBP/WEBM); removed detailed persistent cache TODO section; rewrote Future Improvements to focus on disk-cached encrypted blobs and download progress indication; updated Key Achievements and Current Status/Next Steps to reflect actual implementation scope (file validation, macro detection, image sanitization, in-memory cache only).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • AndreaDiazCorreia
  • mostronatorcoder
  • grunch

Poem

🐰 Whiskers twitch with glee,
Specs are clean, no more TODOs be,
JPEG and PNG, MP4 so fine,
Encrypted blobs on disk—designs align!
Progress flows like carrots divine! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: removing fictional SessionFileCache documentation and rewriting the Future Improvements section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs-media-encrypted-chat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants