Support binary/octet-stream

MorbZ · Mar 5, 2019 · 2012edd · 2012edd
1 parent aad66df
commit 2012edd
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/app/manifest.json b/app/manifest.json
@@ -2,7 +2,7 @@
     "manifest_version": 2,
     "name": "No PDF Download",
     "description": "Opens all PDF files directly in the browser.",
-    "version": "1.0.4",
+    "version": "1.0.5",
 
     "permissions": [
         "webRequest",

diff --git a/app/src/headers.js b/app/src/headers.js
@@ -12,6 +12,10 @@ const PDF_MIME_TYPES = [
     'application/acrobat',
     'applications/vnd.pdf',
 ];
+const BINARY_MIME_TYPES = [
+    'application/octet-stream',
+    'binary/octet-stream',
+];
 const HEADER_CONTENT_DISPOSITION = 'Content-Disposition';
 const HEADER_CONTENT_TYPE = 'Content-Type';
 
@@ -38,7 +42,7 @@ function isPdf(url, type, disposition) {
     }
 
     // Octet-streams may be PDFs, we have to check the extension
-    if(mimeType != 'application/octet-stream') {
+    if(!BINARY_MIME_TYPES.includes(mimeType)) {
         return false;
     }
 

diff --git a/test/test/test.js b/test/test/test.js
@@ -101,6 +101,14 @@ describe('Handle Headers', () => {
         ['Content-Type', 'application/pdf'],
         ['Content-Disposition', 'inline'],
     ]);
+
+    testHandleHeaders('Binary/Octet-stream with PDF file name(s)', 'http://test.com/02000', [
+        ['Content-Disposition', 'attachment; filename="ABC_2019.pdf"; filename*=UTF-8\'\'ABC_2019.pdf'],
+        ['Content-Type', 'binary/octet-stream'],
+    ], [
+        ['Content-Disposition', 'inline; filename="ABC_2019.pdf"; filename*=UTF-8\'\'ABC_2019.pdf'],
+        ['Content-Type', 'application/pdf'],
+    ]);
 });
 
 /* Helper Functions */