fix(minidb): silence the transform-types warning from the dev worker - #2632
Merged
Conversation
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A — dev-experience fix
Problem
After the v2 engine became the default, running
make devprintsExperimentalWarning: Transform Types is an experimental featuredirectly into the TUI at startup (once per worker thread), looking like an error.Root cause: the minidb text-build worker added in #2604 runs its TypeScript source directly in dev via
new Worker('./text-build-worker.ts', { execArgv: ['--experimental-transform-types'] }). Every worker thread emits the experimental warning to stderr, and the v2 session index build at startup spawns it.What changed
--disable-warning=ExperimentalWarningto the source-mode worker'sexecArgvinpackages/minidb/src/worker/text-build.ts. The packaged CLI is unaffected: it uses the prebuilt JS worker withexecArgv: [].Verified:
execArgvwarns, the new one does not, and the worker still runs.pnpm -C packages/minidb testpasses (531 passed, 1 skipped).Checklist
gen-changesetsskill, or this PR needs no changeset. (No changeset — dev-only warning suppression, not perceivable in the shipped CLI)gen-docsskill, or this PR needs no doc update. (N/A — internal dev tooling)