chore(web): replace apps/kimi-web with the code-app web bundle - #2599
Open
liruifengv wants to merge 7 commits into
Open
chore(web): replace apps/kimi-web with the code-app web bundle#2599liruifengv wants to merge 7 commits into
liruifengv wants to merge 7 commits into
Conversation
The web UI source now lives in the code-app repo (apps/web); this repo only ships the prebuilt bundle at apps/kimi-code/dist-web, synced from code-app via \. - delete apps/kimi-web (source, tests, docs) - root package.json: drop dev:web and the kimi-web typecheck leg - apps/kimi-code: drop the workspace dep and the build-from-source step; replace copy-web-assets.mjs with check-web-assets.mjs so packaging fails fast when the committed bundle is missing - CI: _native-build verifies the committed bundle instead of building from source; ci.yml and pkg-pr-new.yml drop the kimi-web legs - docs: AGENTS.md project map, changeset README, gen-changesets and sync-changelog skills now key web UI entries on dist-web
🦋 Changeset detectedLatest commit: ef93478 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
❌ Nix build failed Hash mismatch in
Please update |
commit: |
The ignore entry predates the code-app sync flow, when dist-web was a local build artifact. The bundle is now the canonical, committed form of the web UI, so ignoring it only forces every sync to git add -f.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d16e76c8b8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The web: prefix convention and the web-specific dedup guidance belonged to the in-repo web app. With the source moved to code-app, web UI changes follow the same generic rules as any other CLI-bundle change.
- flake.nix: drop apps/kimi-web from the source fileset and package lists, and verify the committed dist-web in the native build phase instead of building the web app from source - .oxlintrc.json: exclude dist-web (a committed build artifact) now that .gitignore no longer hides it from the linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The web UI source now lives in the code-app repo (
apps/web); this repo no longer builds it from source.apps/kimi-webis deleted and the CLI ships the prebuilt bundle synced from code-app, committed atapps/kimi-code/dist-web(gitignored, force-added — 533 files).Going forward, updating the web UI in the CLI = run
KIMI_CODE_REPO=<this checkout> pnpm run sync:webin code-app and commit the resultingdist-webdiff, ideally in the same PR as the behavior change it carries.Changes
apps/kimi-web(292 files: source, tests, docs).package.json: dropdev:weband the@moonshot-ai/kimi-webtypecheck leg.apps/kimi-code: drop the@moonshot-ai/kimi-webworkspace dependency and the build-from-source step;copy-web-assets.mjsis replaced byscripts/check-web-assets.mjs, which fails packaging fast when the committed bundle is missing._native-build.ymlverifies the committed bundle instead of building from source;ci.ymlandpkg-pr-new.ymldrop the kimi-web legs.AGENTS.mdproject map describes the new flow;.changeset/README.mdpackage list and thegen-changesets/sync-changelogskills now keyweb:changelog entries onapps/kimi-code/dist-webinstead ofapps/kimi-web/.Test plan
pnpm run typecheck(full chain incl.build:packages) passesnode apps/kimi-code/scripts/check-web-assets.mjs— bundle present (535 entries)GET /200, fresh asset hash, favicon 200)kap-server/apps/kimi-codesuites: failures reproduce on an untouchedorigin/mainworktree with the same profile (23 vs 24 failing files / 2 vs 2 —ENOTEMPTYtemp-dir teardown races), i.e. pre-existing environment flakes, not regressions from this changeFollow-ups (not in this PR)
dist-webso the bundle's embedded client version matches the CLI version again (currently 0.31.1 vs 0.32.0).