fix(cli): make native install source description platform-aware - #2409
Open
C0d3N1nja97342 wants to merge 2 commits into
Open
fix(cli): make native install source description platform-aware#2409C0d3N1nja97342 wants to merge 2 commits into
C0d3N1nja97342 wants to merge 2 commits into
Conversation
The renderManualUpdateMessage function hardcoded 'native (windows)' for all platforms, but on macOS native installs (script install) DO support auto-update (canAutoInstall returns true for native on non-Windows). The message was misleading macOS users into thinking their install was some kind of Windows setup. Make the native case platform-aware: show 'native (windows)' only on win32, and just 'native' on other platforms.
🦋 Changeset detectedLatest commit: fa7bab1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #2391
Problem
On macOS,
kimi upgradereportsDetected install source: native (windows). Auto-update is not supported on this platform.for script installs. The native install source supports auto-update on macOS (canAutoInstall returns true for non-Windows), but the message was hardcoded to say "native (windows)" for all platforms.What changed
Added
platformparameter (defaults toprocess.platform) torenderManualUpdateMessage. Thenativecase now showsnative (windows)only on win32, and justnativeon other platforms.Checklist