Skip to content

test: cover resumed plan state with empty plan #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xianjianlf2 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

test: cover resumed plan state with empty plan #2284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/node-sdk/test/session-plan-compact-usage-resume.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ describe('Session plan, compact, usage, and resume APIs', () => {
}
});

it.todo('marks resumed plan mode active when the restored plan has no plan data', async () => {
it('marks resumed plan mode active when the restored plan has no plan data', async () => {

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fix the fixture before enabling this legacy resume test

This test now runs, but it never creates the advertised “restored plan has no plan data” state: the session setup calls setPlanMode(true), which currently writes a plan_mode.enter record with an id (packages/agent-core/src/agent/plan/index.ts:39), while removeManualPlanIds only removes/edits plan.enter and plan.manual_enter records. As a result, the wire history still contains the normal plan id and this test largely duplicates the preceding resume test instead of covering the legacy/missing-plan-data path; update the fixture to strip plan_mode.enter’s id or seed an actual legacy record before enabling it.

Useful? React with 👍 / 👎.

const homeDir = await makeTempDir(tempDirs, 'kimi-sdk-resume-legacy-plan-home-');
const workDir = await makeTempDir(tempDirs, 'kimi-sdk-resume-legacy-plan-work-');
await writeTestConfig(homeDir);
Expand Down Expand Up @@ -189,7 +189,10 @@ describe('Session plan, compact, usage, and resume APIs', () => {
await expect(resumed.getStatus()).resolves.toMatchObject({
planMode: true,
});
await expect(resumed.getPlan()).resolves.toBeNull();
await expect(resumed.getPlan()).resolves.toMatchObject({
content: '',
path: expect.stringContaining('/plans/'),
});
} finally {
await resumedHarness.close();
}
Expand Down