Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 表单校验不隐藏错误消息dom #506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ssuperlilei
Copy link
Contributor

@ssuperlilei ssuperlilei commented Aug 9, 2024

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

目前的校验错误信息标签如果没有是隐藏的,校验后出现错误信息页面都撑高,不太好做样式的处理,比如加固定高度校验后不会页面撑高

💡 需求背景和解决方案

1、方便给错误信息的样式处理,比如手动给 error-message 的标签加高度,去掉 v-if 后也不影响现有的交互
2、去掉 v-if="errorMessage"

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 新功能
    • 更新了 wd-cellwd-input 组件,错误消息现在始终呈现,即使没有错误信息,这可能会影响组件的视觉表现。

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit 133a7fc
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/66b58b2d824214000835ec6a
😎 Deploy Preview https://deploy-preview-506--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 3:22am

Copy link

coderabbitai bot commented Aug 9, 2024

Walkthrough

此次更改涉及两个组件,wd-cellwd-input,均对错误信息的渲染逻辑进行了修改。现在,无论 errorMessage 是否有值,错误信息都会始终渲染。这一改变可能导致在 errorMessage 为空或未定义的情况下,组件产生意外的视觉效果。

Changes

文件路径 更改摘要
src/uni_modules/wot-design-uni/components/wd-cell/wd-cell.vue
src/uni_modules/wot-design-uni/components/wd-input/wd-input.vue
移除了条件渲染的错误信息,现在错误信息始终渲染,可能导致空值时的视觉问题。

Sequence Diagram(s)

(此处不生成序列图,因为更改过于简单。)

Poem

🐰 在细雨中,我轻声欢呼,
错误信息不再隐藏于暮。
无论内容是空是满,
组件的变化让我心欢畅。
让我们一起跳跃,迎接新光芒!
✨✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0e6ea3e and 133a7fc.

Files selected for processing (2)
  • src/uni_modules/wot-design-uni/components/wd-cell/wd-cell.vue (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-input/wd-input.vue (1 hunks)
Additional comments not posted (2)
src/uni_modules/wot-design-uni/components/wd-cell/wd-cell.vue (1)

41-41: 始终渲染错误消息元素的潜在视觉影响

移除 v-if="errorMessage" 后,错误消息元素将始终渲染。这可能导致在 errorMessage 为空或未定义时,页面布局出现意外的视觉效果。确保在样式上考虑这些情况,以避免不必要的空白或布局问题。

请确认在 errorMessage 为空或未定义时,布局是否仍然符合预期。

src/uni_modules/wot-design-uni/components/wd-input/wd-input.vue (1)

70-70: 错误消息元素的持续渲染可能影响布局

去掉 v-if="errorMessage" 后,错误消息元素将始终存在于 DOM 中。这可能会在 errorMessage 为空或未定义时导致视觉效果不佳。建议检查和调整样式,以确保在这些情况下不会出现不必要的空白或布局问题。

请确保在 errorMessage 为空或未定义时,布局和视觉效果仍然符合预期。

@Moonofweisheng
Copy link
Owner

可以试试 设置为toast能否解决你的问题。

@ssuperlilei
Copy link
Contributor Author

设置为toast 不行啊, 我想要的是校验页面不会往下挤,
image
image
错误信息直接把表单撑高了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants