Conversation
AquiGorka
force-pushed
the
chore/remove-unused-pg-dep
branch
from
bc5cc5e to
e18878f
Compare
pg (node-postgres) is only used by drizzle-kit for migrations, not at runtime. Having it in deno.json causes drizzle-orm to resolve with pg as a peer dep, which can interfere with OTEL context propagation. The app uses postgres (postgres.js) for all database operations.
AquiGorka
force-pushed
the
chore/remove-unused-pg-dep
branch
from
e18878f to
b26b0b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgand@types/pgfromdeno.jsonimports — only used by drizzle-kit (migrations), not at runtimedeno.lockso drizzle-orm resolves without pg as a peer depContext
With
pgin imports, drizzle-orm resolves asdrizzle-orm@0.44.7_@opentelemetry+api@1.9.0_@types+pg@8.18.0_pg@8.20.0_postgres@3.4.8. This can interfere with OTEL context propagation — the pg module's connection handling conflicts with the postgres.js driver the app actually uses.Without pg:
drizzle-orm@0.44.7_@opentelemetry+api@1.9.0_postgres@3.4.8Test plan
deno task servestarts without errorsdeno task db:migratestill works (drizzle-kit resolves pg independently)