Conversation
- min_machines_running=1 caused the gru machine to auto-stop before passing health checks during bluegreen deploy, failing the rollout - grace_period increased from 15s to 60s to accommodate cross-region cold starts (gru connects to DB in ams)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min_machines_running = 2— both ams and gru machines must stay running, preventing auto-stop from killing gru before health checks pass during bluegreen deploygrace_periodfrom 15s to 60s to accommodate cross-region cold starts (gru connects to DB in ams)Context
Bluegreen deploys were failing because:
min_machines_running = 1allowed Fly to auto-stop the gru machine immediately after creation (ams already satisfied the minimum)Test plan
fly deploycompletes successfully with bluegreen strategy