Fix Issue with Station AI and PAI Not Allowing New Ghost to Take Role.#4071
Draft
SarahRaven wants to merge 3 commits into
Draft
Fix Issue with Station AI and PAI Not Allowing New Ghost to Take Role.#4071SarahRaven wants to merge 3 commits into
SarahRaven wants to merge 3 commits into
Conversation
…verAvailableComponent to fix StationAI ghost swaps
…n use when they ghost.
Contributor
Author
|
Mainly in draft so I can get some assistance on figuring out "why" the deferred removal of the components was done, since the side effect was completely disabling new ghosts on old roles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Removed the RemCompDeferred calls within ToggleableGhostRoleComponent because it was removing the GhostRoleComponent and the GhostTakeoverAvailableComponent from entities and breaking rejoin.
Why / Balance
Players would be able to leave a Vessel AI or Station AI without having to worry about leaving an irreplacable dead core.
Media
Requirements
How to test
Breaking changes
Changelog