Skip to content

Move unGLOB'd globals to GLOB#294

Open
flleeppyy wants to merge 6 commits into
Monkestation:masterfrom
flleeppyy:globals-shit
Open

Move unGLOB'd globals to GLOB#294
flleeppyy wants to merge 6 commits into
Monkestation:masterfrom
flleeppyy:globals-shit

Conversation

@flleeppyy
Copy link
Copy Markdown
Member

@flleeppyy flleeppyy commented May 9, 2026

About The Pull Request

Code cleanup basically. Also refactors some for loops because holy fuck look at this

/mob/living/carbon/human/proc/check_head_coverage()

    var/list/body_parts = list(head, wear_mask, wear_suit, w_uniform)
    for(var/bp in body_parts)
        if(!bp)    continue
        if(bp && istype(bp ,/obj/item/clothing))
            var/obj/item/clothing/C = bp
            if(C.body_parts_covered & HEAD)
                return 1
    return 0

compared to

/mob/living/carbon/human/proc/check_head_coverage()
    var/list/body_parts = list(head, wear_mask, wear_suit, w_uniform)
    for(var/obj/item/clothing/bp in body_parts)
        return (bp.body_parts_covered & HEAD)
    return FALSE

SOOO much nicer yes?

Testing

Changelog

🆑
code: Move unGLOB'd globals to GLOB
/:cl:

@ChiefMonkengineer
Copy link
Copy Markdown
Collaborator

Test merge deployment history:

Test Merge Deployed @ 05/29/2026 00:00:10 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 373b667
Pull Request: bc228b5
Server: d5e497990292b255dc6846b3e120862cbec5a01f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants