Skip to content

Storyteller Fix#284

Open
AltHit wants to merge 8 commits into
Monkestation:masterfrom
AltHit:i-got-a-story-for-ya
Open

Storyteller Fix#284
AltHit wants to merge 8 commits into
Monkestation:masterfrom
AltHit:i-got-a-story-for-ya

Conversation

@AltHit
Copy link
Copy Markdown

@AltHit AltHit commented Apr 24, 2026

About The Pull Request

Highly experimental rework and bugfix of Storyteller system

Main change here is removal of price ramp up after every occurrence of event because it led to price being so high that event could not practically happen in round after few times, thus making long rounds eventless and boring.

TLDR: Cured Storyteller coma after one hour in the round

Storyteller now works in 'pulses'. They spend all their points on all events they can buy once they reach point threshold (~20 minutes for mundane, ~45 minutes for medium and ~90 minutes on major events, depending on storyteller's multipliers and variance coefficient)

Space weather moved to separate pool not to take up points that would've been spent on other interesting events and to make it more regular (it will appear after ~30 minutes into the round and then rotate every 60 minutes or so)

Weighting system was re-weighted using excel sheets to make more sense and to make events more diverse (when was the last time you've actually saw naturally appearing Kaiser?)

With all this - Eris should seem much more alive than usual

Also includes #268 and #270 as it was balanced with those changes in mind a long time ago

Why It's Good For The Game

This PR is aimed to fix issue when it feels like storyteller doesn't do anything in the round (and sometimes it actually didn't)

Testing

Don't trust me bro.

I tested main functions after each change but real general testing is yet to be made

  • Check if it works on MonkeyEris and 494 days after initial release
  • Remove debugging messages

Changelog

🆑
del: Removed nothing event
del: Removed old spacevines
del: Removed wallrot
add: Added separate pool of points for space weather
tweak: Changed sizes of event pools
tweak: Changed prices of several events
fix: Fixed incorrect event prices that prevented some events from spawning
fix: Fixed incorrect event points refunding
tweak: Reweighed some events according to new prices
add: Added new message variations for space graveyard
tweak: Space weather can now appear more than once per round
tweak: Added space weather rotation system to minimize repetitions
tweak: Changed event spawn proc to handle spawning several event at once
fix: Fixed storyteller point gain variation to be more random as it was supposed to be
tweak: Lowered delay between scheduling event and spawning it
del: Removed old event variation system because it stopped events from happening after several hours in the round
/:cl:

@AltHit AltHit marked this pull request as ready for review April 25, 2026 09:55
@Mycah142 Mycah142 added READY FOR REVIEW Mycah's Approval While he didn't QC the code itself, the idea or concept is acceptable. labels May 7, 2026
@ChiefMonkengineer
Copy link
Copy Markdown
Collaborator

ChiefMonkengineer commented May 7, 2026

Test merge deployment history:

Test Merge Deployed @ 05/07/2026 22:47:27 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: c73c5d6
Pull Request: 45ef157
Server: 22f3cc1d93f00603f39dbfd4ee54336b42fae684

Test Merge Updated @ 05/08/2026 01:04:18 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: c73c5d6
Pull Request: 45ef157
Server: b3824d79335c3208ea7a115caaf77f53786e5e43

Test Merge Updated @ 05/08/2026 02:27:52 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 9057086
Pull Request: 45ef157
Server: 68197a75a456e2a4896b446e5d52930792acfc76

Test Merge Updated @ 05/09/2026 03:41:02 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 9057086
Pull Request: 45ef157
Server: 49d1b15d8b909cf1615f35f0c76644e7e7ae1ca4

Test Merge Updated @ 05/09/2026 09:04:20 +00:00:
Server Instance

Monkeris

Merged By

flleeppyy2

Revision

Origin: 9057086
Pull Request: 45ef157
Server: 2a60ce50f77778c7ad95c2009d5d0a3e144ccb64

Test Merge Updated @ 05/09/2026 14:09:56 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 9057086
Pull Request: 45ef157
Server: a08c2097f8274da1ece9fccffff02606cd661394

Test Merge Updated @ 05/09/2026 16:35:05 +00:00:
Server Instance

Monkeris

Merged By

flleeppyy2

Revision

Origin: 9057086
Pull Request: 45ef157
Server: c3a681dfef43e89036c951d5fbd161219e183457

Test Merge Updated @ 05/09/2026 19:24:58 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 9057086
Pull Request: 45ef157
Server: d97a7777d19d6014c2cc529b5db3c7344c3de233

Test Merge Updated @ 05/09/2026 22:16:51 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 9057086
Pull Request: 45ef157
Server: c8c3367f09a1e71ea2ee668425a9a2332e067d45

Test Merge Updated @ 05/09/2026 22:22:17 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 9057086
Pull Request: 45ef157
Server: 016c26b4a46e869273c70c03bf3b38841e825cb7

Test Merge Updated @ 05/12/2026 21:20:47 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: c872e31
Pull Request: 20fcb8a
Server: 50aa4327ac521f5bafb8d4a6c3847afa6b75fe98

Test Merge Updated @ 05/12/2026 21:36:37 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: c872e31
Pull Request: 20fcb8a
Server: e82fb92ebaa4193c70c0328a8141f359319e46fa

Test Merge Updated @ 05/12/2026 21:46:23 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: c872e31
Pull Request: 20fcb8a
Server: fc52d89857745a07ba506703ad1f683b8f37725e

Test Merge Updated @ 05/13/2026 20:54:50 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 6d29cb2
Pull Request: 20fcb8a
Server: 3a3d8e520949d5f0708f3127ffee155ede01b57e

Test Merge Updated @ 05/13/2026 21:03:25 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: a17a917
Pull Request: 20fcb8a
Server: 7161ef32e6d58c93b94c01d9cf347527131c5acd

Test Merge Updated @ 05/19/2026 02:24:38 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 19e057d
Pull Request: 02dfa76
Server: 7ccf658d195266805128457c6eed5514d1eae61c

Test Merge Updated @ 05/22/2026 13:59:02 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 19e057d
Pull Request: 02dfa76
Server: b336c65611545c380b870a3955e32e198dca52f2

Test Merge Updated @ 05/22/2026 14:24:38 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 19e057d
Pull Request: 02dfa76
Server: 6f533edb66556c9e874b43479e5d6a82495a4b2c

Test Merge Updated @ 05/22/2026 16:43:32 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 19e057d
Pull Request: 02dfa76
Server: e469cbe25824ca95e7500b0069711d11c4b74bc2

Test Merge Updated @ 05/22/2026 17:26:12 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 19e057d
Pull Request: 02dfa76
Server: c9b33be923aad21939002f0b691782fa50669b1e

Test Merge Updated @ 05/22/2026 19:12:25 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 19e057d
Pull Request: 02dfa76
Server: 17d34cd46cea42b5b18feefd3205454b5e9697ae

Test Merge Updated @ 05/23/2026 01:08:28 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 9dd08ec
Pull Request: 02dfa76
Server: 9958955de205b334f96ca1ffa312127f449e8dff

Test Merge Updated @ 05/23/2026 01:54:00 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 9dd08ec
Pull Request: 02dfa76
Server: ad415a1f92682eaecbe8251deeed0ea0067dd938

Test Merge Updated @ 05/23/2026 01:56:46 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 9dd08ec
Pull Request: 02dfa76
Server: a4383c82e1b6464d0e22cbbe0ffac480042bfe0e

Test Merge Updated @ 05/23/2026 16:08:21 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 56ed96c
Pull Request: 02dfa76
Server: e5c82454b3684f2629c4f1be9888724a2396b555

Test Merge Updated @ 05/23/2026 16:11:08 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 56ed96c
Pull Request: 02dfa76
Server: 470dbbaf090992fc5a1bcb318e894e52a69867be

Test Merge Updated @ 05/23/2026 17:05:38 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 56ed96c
Pull Request: 02dfa76
Server: 0ec291f01798d0a64379c532edcc312a81ffc2b8

Test Merge Updated @ 05/28/2026 16:56:27 +00:00:
Server Instance

Monkeris

Merged By

flleeppyy2

Revision

Origin: 739979c
Pull Request: 02dfa76
Server: d4d9097a855d512a21e6e98faedf44906e450c28

Test Merge Updated @ 05/29/2026 00:00:10 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 373b667
Pull Request: 02dfa76
Server: d5e497990292b255dc6846b3e120862cbec5a01f

Test Merge Updated @ 06/05/2026 16:02:03 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: f700901
Pull Request: 02dfa76
Server: 86213466db2ba01a7d9f9941c024b633d948260b

Test Merge Updated @ 06/05/2026 22:45:04 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: f700901
Pull Request: 02dfa76
Server: 011217c94cc50cede676e54ce62cfe7803e466c3

@Mycah142
Copy link
Copy Markdown
Collaborator

Mycah142 commented May 8, 2026

Is it intentional for the storyteller to try and spawn Excels when Excels already exist and are still alive?

@AltHit
Copy link
Copy Markdown
Author

AltHit commented May 9, 2026

Is it intentional for the storyteller to try and spawn Excels when Excels already exist and are still alive?

Well... No. Fix is already committed in excel update branch.
Now it checks if Centor (main excel building is alive or not) and if there's none - it can spawn excels

Theoretically if excels spawned but haven't placed their Centor yet - second wave can still trigger. But it would also mean that excels didn't yet do anything so... fair?

Apparently it was normal eris behaviour but storytellers were too bugged to spawn excel twice

@Mycah142
Copy link
Copy Markdown
Collaborator

Mycah142 commented May 9, 2026

You can commit it to this branch, as it's only TM'd and not fully merged. Keep me posted on Discord and I'll slide it into place once you commit here.

Copy link
Copy Markdown
Member

@flleeppyy flleeppyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been test-merged for a while, i see no issues with this code at face value after staring at it for 10 minutes, so long as @Mycah142 approves of the balance changes and new weather roleset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mycah's Approval While he didn't QC the code itself, the idea or concept is acceptable. READY FOR REVIEW

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants