Merge pull request #8 from goodjack/master

Add Response layer

src/Commands/ResponseMakeCommand.php

@@ -0,0 +1,45 @@
+<?php
+
+namespace Yish\Generators\Commands;
+
+use Illuminate\Console\GeneratorCommand;
+
+class ResponseMakeCommand extends GeneratorCommand
+{
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $name = 'make:response';
+
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    protected $description = 'Create a new response class';
+
+    protected $type = 'Response';
+
+    /**
+     * Get the stub file for the generator.
+     *
+     * @return string
+     */
+    protected function getStub()
+    {
+        return __DIR__ . '/../stubs/response.stub';
+    }
+
+    /**
+     * Get the default namespace for the class.
+     *
+     * @param  string  $rootNamespace
+     * @return string
+     */
+    protected function getDefaultNamespace($rootNamespace)
+    {
+        return $rootNamespace.'\Responses';
+    }
+}

src/GeneratorsServiceProvider.php

@@ -11,6 +11,7 @@
 use Yish\Generators\Commands\FoundationMakeCommand;
 use Yish\Generators\Commands\ParserMakeCommand;
 use Yish\Generators\Commands\TransportMakeCommand;
+use Yish\Generators\Commands\ResponseMakeCommand;
 
 class GeneratorsServiceProvider extends ServiceProvider
 {
@@ -32,6 +33,7 @@ class GeneratorsServiceProvider extends ServiceProvider
         'FoundationMake' => 'command.foundation.make',
         'ParserMake' => 'command.parser.make',
         'TransportMake' => 'command.transport.make',
+        'ResponseMake' => 'command.response.make',
     ];
 
     /**
@@ -42,7 +44,8 @@ class GeneratorsServiceProvider extends ServiceProvider
     public function register()
     {
         $this->registerCommands(array_merge(
-            $this->commands, $this->devCommands
+            $this->commands,
+            $this->devCommands
         ));
     }
 
@@ -156,4 +159,16 @@ protected function registerFoundationMakeCommand()
             return new FoundationMakeCommand($app['files']);
         });
     }
+
+    /**
+     * Register the command.
+     *
+     * @return void
+     */
+    protected function registerResponseMakeCommand()
+    {
+        $this->app->singleton('command.response.make', function ($app) {
+            return new ResponseMakeCommand($app['files']);
+        });
+    }
 }

src/stubs/response.stub

@@ -0,0 +1,13 @@
+<?php
+
+namespace DummyNamespace;
+
+use Illuminate\Contracts\Support\Responsable;
+
+class DummyClass implements Responsable
+{
+    public function toResponse($request)
+    {
+        //
+    }
+}

tests/Illuminate/Responses/UserResponse.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace Yish\Generators\Tests\Illuminate\Responses;
+
+use Illuminate\Contracts\Support\Responsable;
+use Illuminate\Support\Collection;
+
+class UserResponse implements Responsable
+{
+    protected $users;
+
+    public function __construct(Collection $users)
+    {
+        $this->users = $users;
+    }
+
+    public function toResponse($request)
+    {
+        return response()->json($this->transform());
+    }
+
+    public function transform()
+    {
+        return $this->users->map(function ($user) {
+            return [
+                'name' => $user->name,
+                'email' => $user->email,
+            ];
+        });
+    }
+}

tests/ResponseTest.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace Yish\Generators\Tests;
+
+use Illuminate\Database\Eloquent\Collection;
+use Illuminate\Support\Facades\Route;
+use Yish\Generators\Tests\Illuminate\Responses\UserResponse;
+use Yish\Generators\Tests\Illuminate\User as FakeUser;
+
+class ResponseTest extends TestCase
+{
+    /**
+     * @test
+     * @group package-foundation
+     */
+    public function it_should_return_specific_data()
+    {
+        $userYish = [
+            'id' => 1,
+            'name' => 'yish',
+            'email' => '[email protected]',
+            'password' => bcrypt(123456),
+        ];
+
+        $userGoodjack = [
+            'id' => 2,
+            'name' => 'goodjack',
+            'email' => '[email protected]',
+            'password' => bcrypt(123456),
+        ];
+
+        $users = new Collection([
+            new FakeUser($userYish),
+            new FakeUser($userGoodjack),
+        ]);
+
+        Route::get('/user', function () use ($users) {
+            return new UserResponse($users);
+        });
+
+        $expected = $users->map(function ($user) {
+            return [
+                'name' => $user->name,
+                'email' => $user->email,
+            ];
+        });
+
+        $this->get('/user')
+            ->assertJsonFragment($expected[0])
+            ->assertJsonFragment($expected[1]);
+    }
+}