Skip to content

fix: correct vision FA3 arguments and fallback handling - #1641

Merged
shihaobai merged 2 commits into
ModelTC:mainfrom
sufubao:fix-vit-fa3
Oct 19, 2026
Merged

shihaobai merged 2 commits into
ModelTC:mainfrom
sufubao:fix-vit-fa3

Conversation

@sufubao

@sufubao sufubao commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

视觉 attention 的两处 SGL FA3 调用补齐 sparse_mask_fine=None 和 only_qv=False 参数,适配对应接口。

同时修复 FA3 异常后的回退流程:此前仅禁用后续 FA3 调用,本次输出可能未计算或只写入一部分;现在本次立即用 Triton 重新计算,FA3 成功时直接返回。

验证:FA3 失败后同次回退、后续继续回退及成功时不回退的两个单元测试通过。未运行 GPU 数值和性能测试。

这两项修复从 #1585 拆出,独立审查。

@shihaobai
shihaobai merged commit 5966076 into ModelTC:main Oct 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants