Repository navigation
fix: correct vision FA3 arguments and fallback handling - #1641
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
视觉 attention 的两处 SGL FA3 调用补齐
sparse_mask_fine=None和only_qv=False参数,适配对应接口。同时修复 FA3 异常后的回退流程:此前仅禁用后续 FA3 调用,本次输出可能未计算或只写入一部分;现在本次立即用 Triton 重新计算,FA3 成功时直接返回。
验证:FA3 失败后同次回退、后续继续回退及成功时不回退的两个单元测试通过。未运行 GPU 数值和性能测试。
这两项修复从 #1585 拆出,独立审查。