-
Notifications
You must be signed in to change notification settings - Fork 29
[feat] hotness management for gc #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| /** | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2025 Huawei Technologies Co., Ltd. All rights reserved. | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| * */ | ||
| #ifndef UNIFIEDCACHE_TIMER_H | ||
| #define UNIFIEDCACHE_TIMER_H | ||
|
|
||
| #include <chrono> | ||
| #include <thread> | ||
| #include <mutex> | ||
| #include <atomic> | ||
| #include <condition_variable> | ||
| #include "logger/logger.h" | ||
| #include "status/status.h" | ||
|
|
||
| namespace UC { | ||
|
|
||
| template <typename Callable> | ||
| class Timer { | ||
| public: | ||
| Timer(const std::chrono::seconds& interval, Callable&& callable) | ||
| : interval_(interval), callable_(callable), running_(false) {} | ||
| ~Timer() { | ||
| { | ||
| std::lock_guard<std::mutex> lg(this->mutex_); | ||
| this->running_ = false; | ||
| } | ||
|
|
||
| this->cv_.notify_one(); | ||
| if (this->thread_.joinable()) { this->thread_.join(); } | ||
| } | ||
| Status Start() | ||
| { | ||
| { | ||
| std::lock_guard<std::mutex> lg(this->mutex_); | ||
| if (this->running_) { return Status::OK(); } | ||
| } | ||
| try { | ||
| this->running_ = true; | ||
| this->thread_ = std::thread(&Timer::Runner, this); | ||
| return Status::OK(); | ||
| } catch (const std::exception& e) { | ||
| UC_ERROR("Failed({}) to start timer.", e.what()); | ||
| return Status::OutOfMemory(); | ||
| } | ||
| } | ||
|
|
||
| private: | ||
| void Runner() | ||
| { | ||
| while (this->running_) { | ||
| try { | ||
| { | ||
| std::unique_lock<std::mutex> lg(this->mutex_); | ||
| this->cv_.wait_for(lg, this->interval_, [this] { return !this->running_; }); | ||
| if (!this->running_) { break; } | ||
| } | ||
| this->callable_(); | ||
| } catch (const std::exception& e) { UC_ERROR("Failed({}) to run timer.", e.what()); } | ||
| } | ||
| } | ||
|
|
||
| private: | ||
| std::chrono::seconds interval_; | ||
| Callable callable_; | ||
| std::thread thread_; | ||
| std::mutex mutex_; | ||
| std::condition_variable cv_; | ||
| std::atomic<bool> running_; | ||
| }; | ||
|
|
||
| } // namespace UC | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /** | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2025 Huawei Technologies Co., Ltd. All rights reserved. | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| * */ | ||
|
|
||
| #ifndef UNIFIEDCACHE_HOTNESS_MANAGER_H | ||
| #define UNIFIEDCACHE_HOTNESS_MANAGER_H | ||
|
|
||
| #include <atomic> | ||
| #include <functional> | ||
| #include "hotness_set.h" | ||
| #include "hotness_timer.h" | ||
| #include "logger/logger.h" | ||
|
|
||
| namespace UC { | ||
|
|
||
| class HotnessManager { | ||
| public: | ||
| Status Setup(const size_t interval, const SpaceLayout* spaceLayout) | ||
| { | ||
| this->hotnessTimer_.SetInterval(interval); | ||
| this->layout_ = spaceLayout; | ||
| this->setupSuccess_ = true; | ||
| return Status::OK(); | ||
| } | ||
|
|
||
| void Visit(const std::string& blockId) | ||
| { | ||
| if (!this->setupSuccess_) { | ||
| return; | ||
| } | ||
|
|
||
| this->hotnessSet_.Insert(blockId); | ||
| auto old = this->serviceRunning_.load(std::memory_order_acquire); | ||
| if (old) { return; } | ||
| if (this->serviceRunning_.compare_exchange_weak(old, true, std::memory_order_acq_rel)) { | ||
| auto updater = std::bind(&HotnessSet::UpdateHotness, &this->hotnessSet_, this->layout_); | ||
| if (this->hotnessTimer_.Start(std::move(updater)).Success()) { | ||
| UC_INFO("Space hotness service started."); | ||
| return; | ||
| } | ||
| this->serviceRunning_ = old; | ||
| } | ||
| } | ||
|
|
||
| private: | ||
| bool setupSuccess_{false}; | ||
| std::atomic_bool serviceRunning_{false}; | ||
| const SpaceLayout* layout_; | ||
| HotnessSet hotnessSet_; | ||
| HotnessTimer hotnessTimer_; | ||
| }; | ||
|
|
||
| } // namespace UC | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /** | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2025 Huawei Technologies Co., Ltd. All rights reserved. | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| * */ | ||
|
|
||
| #include "hotness_set.h" | ||
| #include "logger/logger.h" | ||
| #include "file/file.h" | ||
| #include "template/singleton.h" | ||
| namespace UC { | ||
|
|
||
| void HotnessSet::Insert(const std::string& blockId) | ||
| { | ||
| std::lock_guard<std::mutex> lg(this->mutex_); | ||
| this->pendingBlocks_.insert(blockId); | ||
| } | ||
|
|
||
| void HotnessSet::UpdateHotness(const SpaceLayout* spaceLayout) | ||
| { | ||
| std::unordered_set<std::string> blocksToUpdate; | ||
| { | ||
| std::lock_guard<std::mutex> lg(this->mutex_); | ||
| if (this->pendingBlocks_.empty()) { | ||
| return; | ||
| } | ||
| blocksToUpdate.swap(this->pendingBlocks_); | ||
| } | ||
|
|
||
| size_t number = 0; | ||
| for (const std::string& blockId : blocksToUpdate) { | ||
| auto blockPath = spaceLayout->DataFilePath(blockId, false); | ||
| auto file = File::Make(blockPath); | ||
| if (!file) { | ||
| UC_WARN("Failed to make file({}), blockId({}).", blockPath, blockId); | ||
| continue; | ||
| } | ||
| auto status = file->UpdateTime(); | ||
| if (status.Failure()) { | ||
| UC_WARN("Failed({}) to update time({}), blockId({}).", status, blockPath, blockId); | ||
| continue; | ||
| } | ||
| number++; | ||
| } | ||
| if (blocksToUpdate.size() == number) { | ||
| UC_INFO("All blocks are hotness."); | ||
| } else { | ||
| UC_WARN("{} of {} blocks are hotness.", blocksToUpdate.size() - number, blocksToUpdate.size()); | ||
| } | ||
| } | ||
|
|
||
| } // namespace UC |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.