Skip to content

Conversation

@hero0307
Copy link
Contributor

…d network resources

Purpose

Add import checking functionality to trace_replay and fix the issue of unclosed network resources

Modifications

Add import checking functionality to trace_replay and fix the issue of unclosed network resources

Test

You can run trace_replay.py.
If you haven't installed openpyxl, you will be prompted to install it at the start of the run, instead of being reminded to install it at the end as before.
Meanwhile, the "unclosed client session" warning will no longer appear.

@flesher0813
Copy link
Contributor

Maybe using await session.close() at the end of func replay_trace_by_time can solve the "unclosed client session" warning?

@hero0307
Copy link
Contributor Author

Maybe using await session.close() at the end of func replay_trace_by_time can solve the "unclosed client session" warning?

If an exception occurs during execution when using this method, the session will not be closed. Using async with will automatically handle resource cleanup.

@flesher0813 flesher0813 merged commit 022e187 into ModelEngine-Group:develop Oct 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants