Rewrite dramstore using the reconstructed task architecture #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenyuZhu1
requested review from
harrisonyhq,
mag1c-h and
ygwpz
as code owners
…uZhu1/unified-cache-management into develop_Klukowski_new_dram
qyh111
reviewed
Oct 23, 2025
| class MemoryPool { | ||
| public: | ||
| MemoryPool(size_t capacity, size_t blockSize) | ||
| : pool_(new char[capacity]), |
There was a problem hiding this comment.
better use pinned memory here
| return 0 | ||
| capacity = int(config.get("capacity", 1073741824)) # Default 1GB | ||
| block_size = int(config.get("kv_block_size", 262144)) # Default 256KB | ||
| device_id = int(config.get("device_id", -1)) |
There was a problem hiding this comment.
kv_block_size is a concept within NfsStore, representing the total size of all layers of kv-cache contained in a single block. It seems that it is iosize not kv_block_size
| // TODO: H2D | ||
| status = this->H2D(shard, device); | ||
| } | ||
| this->Done(shard, device, status.Success()); |
There was a problem hiding this comment.
Since we use Async copy here ,it seems we shouldn't synchronize every shard
qyh111
reviewed
Oct 23, 2025
| size_t capacity_; | ||
| size_t blockSize_; | ||
|
|
||
| std::unordered_map<std::string, char*> addressMap_; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memPool is based on PR #285, while the reconstructed dramstore is based on PR #296
Related unittests: ucm/store/test/case/infra/mem_pool_test.cc
Results of the performance test (dramstore_embed_and_fetch.py):
