Skip to content

Conversation

jsbjfkbsjk
Copy link
Contributor

@jsbjfkbsjk jsbjfkbsjk commented Aug 22, 2025

🔗 相关问题 / Related Issue

Issue 链接 / Issue Link: #166

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 📦 依赖升级 / Dependency upgrade (update dependencies to newer versions)
  • 🚀 功能增强 / Feature enhancement (improve existing functionality without breaking changes)
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

修复了应用复制后头像不显示和window系统不显示头像的问题

📋 主要变更 / Brief Changelog

原问题:

  • 1.应用复制时icon取的是旧应用的图标,当旧应用删除时新应用图标也会消失。
  • 2.在window系统中上传文件时获得的文件路径是带有盘符的,如D:\var\share,前端未作处理,无法正常显示。
  • 3.不仅是复制的接口,在应用编辑的接口也混用了url。
  • 4.前端在混用了回显图标的url和成功复制后写入数据库的url。
    改动:
  • 1.应用复制时在copy-app重写一遍上传文件的逻辑,把旧应用的图标重新上传一次,这样就得到克隆的版本。
  • 2.在上传文件接口中当上传文件成功后使用正则处理取出文件名字,并分别拼接出回显用url和写入数据库的url
  • 3.修复了编辑应用时的图片回显问题

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

通过浏览器抓包。

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

image 应用分页查询图标显示正常。抓包查看url可知url正常 image image 点击复制按钮图片正常显示。 抓包可知先进行了一个旧图标的上传,上传成功后回显使用了新的图标地址 image 换张新图片也可以正常显示 image 复制后成功显示图片 image 应用编辑页面可以正常显示 image 正常回显 image 修改后也正常回显 image 修改成功后也正常回显 image

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过:mvn -B clean package -Dmaven.test.skip=truenpm install --force && npm run build:pro / Basic checks pass
  • 单元测试通过:mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes

本次改动只针对window系统

审查者注意事项 / Reviewer Notes:

@CodeCasterX CodeCasterX linked an issue Sep 29, 2025 that may be closed by this pull request
@CodeCasterX CodeCasterX added type: bug A general bug in: builder Issues in app-builder modules labels Sep 29, 2025
@CodeCasterX CodeCasterX added this to the 1.2.4 milestone Sep 29, 2025
@desAweis desAweis modified the milestones: 1.2.4, 1.3.0 Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: builder Issues in app-builder modules type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

应用复制设置头像不生效
5 participants