Prevent undefined behavior when using QString::chopped

[Liderate]

This small change is based on a note in the Qt documentation for QString::chopped which states "The behavior is undefined if len is negative or greater than size()." I did not see any other instance of chopped in the codebase that needs changed.

[Holt59]

I don't think QString::chopped should be used here, this looks really weird, we probably want QString::mid.

[Holt59]

According to 9dbac13, chopped() was added to "Limit the download file description to 4096 characters", but that is not what chopped does so clearly this should be changed to simply info->description.mid(0, 4096).

[Holt59]

I made a separate PR for this with mid. For information, I looked at Qt sources, and in 6.7.1, chopped(4096) was equivalent to sliced(0, size() - 4096) which is equivalent to QString(begin(), size() - 4096), so

• when size() would be less than 4096 (most of the time since according to the previous commit, Nexus description are limited to 255 characters), this is equivalent of QString(begin(), -1) so the size is computed from the QString and the full string is returned - So not "UB" as per the C++ standard.
• when size() would be greater than 4096, this would basically keep the left-most size() - 4096 characters, so pretty weird output (also in that case, the original description is probably already bad).

[Liderate]

That makes sense. I appreciate the detailed response.