Parse unmanaged file location when creating ModInfoForeign #2053
Conversation
Silarn
commented
Jun 16, 2024
Silarn
commented
- Fixes issues with secondaryDataDirectories
- Fixes issues with secondaryDataDirectories
| QMap<QString, QDir> directories = {{"data", game->dataDirectory()}}; | ||
| directories.insert(game->secondaryDataDirectories()); | ||
| for (QDir directory : directories) { | ||
| if (referenceFile.startsWith(directory.absolutePath(), Qt::CaseInsensitive)) { |
There was a problem hiding this comment.
Maybe there is a better way in Qt to check if a file is under a directory?
There was a problem hiding this comment.
A quick search didn't find anything but there may be a way.
There was a problem hiding this comment.
Still haven't found a better solution for this. It seems to work.
- Use organizercore to get game plugin - Use QList
|
I'm still trying to figure out what exactly prevents origins (mods) from having the root directory set as an 'alternate' so that they don't display conflicts. This isn't working for the 'secondaryDataDirectories' origins so the UI is displaying all of the unmanaged mods as conflicts with 'game_data'. If anyone else can shed light on this, I'd be grateful. Maybe I'm too tired right now. |
- CCC implementation prevents the need to determine core plugin LO by dependency chains
|
@Silarn Just to be sure, this is kind of independent from the Starfield PR? I.e., can be merged independently? |
|
While the changes are somewhat related to stuff that was done for Starfield, this shouldn't be dependent on any of the Starfield plugin changes. It's really more of a bugfix that primarily affects Starfield. |
|
I'd still like to determine where MO is ignoring the root 'data' origin when determining alternates so that the secondary data directory doesn't get highlighted as a conflict. |
- I had expected the opposite, but apparently the light flag still wins if both are set. This shouldn't really happen but it's possible, even with the CK
- Show both icons, warn if both set
