Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from fmtlib to std::format. #2031

Merged
merged 3 commits into from
May 25, 2024
Merged

Switch from fmtlib to std::format. #2031

merged 3 commits into from
May 25, 2024

Conversation

Holt59
Copy link
Member

@Holt59 Holt59 commented May 21, 2024

See ModOrganizer2/modorganizer-uibase#143

I removed all the manual call to toStdString() after tr, that's on purpose - Since std::string is convertible to std::format_string, that would trigger the format_string overload, but since the expression would not be compile time, fail.

Supersedes #2027

Others:

  • Remove libffi from dependencies in Github action.

@Holt59 Holt59 merged commit fa82d1c into master May 25, 2024
3 checks passed
@Holt59 Holt59 mentioned this pull request May 25, 2024
@Holt59 Holt59 deleted the dev/stdformat branch June 29, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant