Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Plugin sorting updates #1894

Merged
merged 3 commits into from
Oct 4, 2023
Merged

WIP: Plugin sorting updates #1894

merged 3 commits into from
Oct 4, 2023

Conversation

Silarn
Copy link
Member

@Silarn Silarn commented Oct 2, 2023

  • Add enabledPlugins for core plugins which are enabled but NOT auto-loaded (may need to be written to plugins.txt or have an ambiguous load order position)
  • General Starfield updates
    • Add enabledPlugins for "BlueprintShips-Starfield.esm"
    • Disable plugin management if sTestFile is in use (also applies to FO4)
    • Write the enabledPlugins to plugins.txt to enforce base game load order
    • Allow for LOOT sorting (dynamic based on settings)
  • Incorporate enabledPlugins into force enabled plugins in plugin list
  • Update various interface layers

TODO: Fix sort button to dynamically update if status changes
TODO: Auto refresh lists if the INI Editor is closed

- Add enabledPlugins for core plugins which are enabled but NOT auto-loaded (may need to be written to plugins.txt or have an ambiguous load order position)
- General Starfield updates
  - Add enabledPlugins for "BlueprintShips-Starfield.esm"
  - Disable plugin management if sTestFile is in use (also applies to FO4)
  - Write the enabledPlugins to plugins.txt to enforce base game load order
  - Allow for LOOT sorting (dynamic based on settings)
- Incorporate enabledPlugins into force enabled plugins in plugin list
- Update various interface layers

TODO: Fix sort button to dynamically update if status changes
TODO: Auto refresh lists if the INI Editor is closed
Silarn added 2 commits October 2, 2023 18:28
- Mirrors LOOT functionality
- Rename 'forceEnabled' to 'forceLoaded' to better reflect the difference
@Silarn Silarn marked this pull request as ready for review October 2, 2023 23:51
@Silarn Silarn requested review from Al12rs and Holt59 October 2, 2023 23:51
@Silarn
Copy link
Member Author

Silarn commented Oct 2, 2023

After taking a look, there's really not a great way to tell when tools are 'finished' with the current plugin structure. It might be useful to implement eventually but seemed beyond the scope of this change.

For now, users will have to manually trigger a refresh if they change the INIs such that it would alter the plugin pane.

The settings changes and general refresh will now correctly update both the plugins and sort button state.

@Silarn Silarn merged commit f8a3d5b into master Oct 4, 2023
3 checks passed
@Silarn Silarn deleted the loot_0_22 branch October 4, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant