Default profile settings #1869
Merged
Default profile settings #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still needed? Or did the starfield PR also include these changes? |
|
It was included in Starfield, you're right. |
|
Actually, maybe it wasn't. Now I wonder if I remembered to include it in some of those builds. |
|
Yeah, this should be merged if there are no issues. I think my recent build included it because it was pulled into the category code but I might have skipped this change for a build or two. It's needed to keep new user confusion to a minimum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly contained change which adds a set to the instance creation dialog and general settings to set up defaults for the profile settings. (profile INIs, saves, and automatic archive invalidation)
There's a lot of confusion generated when profile INIs are enabled by default but not archive invalidation. People think they've modified the INIs but now the game is loading a different copy they didn't know about. As much as it is a user knowledge issue, it's also a pain point for people learning the application.
The current default during instance creation is just to enable archive invalidation. Most people will probably leave it alone, and the people who know what they are can choose their preference. I've tried to test a few different ways. Once the settings get saved to the profile config, it should be sticky. Only new profiles should pick up the defaults. But it's worth more testing.