Remove unnecessary plugincontainer from settings

ModOrganizer2 · Sep 24, 2023 · 11522cf · 11522cf
1 parent 4bd860a
commit 11522cf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/src/settingsdialog.cpp b/src/settingsdialog.cpp
@@ -37,8 +37,8 @@ SettingsDialog::SettingsDialog(PluginContainer* pluginContainer, Settings& setti
 {
   ui->setupUi(this);
 
-  m_tabs.push_back(std::unique_ptr<SettingsTab>(
-      new GeneralSettingsTab(settings, m_pluginContainer, *this)));
+  m_tabs.push_back(
+      std::unique_ptr<SettingsTab>(new GeneralSettingsTab(settings, *this)));
   m_tabs.push_back(std::unique_ptr<SettingsTab>(new ThemeSettingsTab(settings, *this)));
   m_tabs.push_back(
       std::unique_ptr<SettingsTab>(new ModListSettingsTab(settings, *this)));

diff --git a/src/settingsdialoggeneral.cpp b/src/settingsdialoggeneral.cpp
@@ -8,9 +8,8 @@
 
 using namespace MOBase;
 
-GeneralSettingsTab::GeneralSettingsTab(Settings& s, PluginContainer* pluginContainer,
-                                       SettingsDialog& d)
-    : SettingsTab(s, d), m_PluginContainer(pluginContainer)
+GeneralSettingsTab::GeneralSettingsTab(Settings& s, SettingsDialog& d)
+    : SettingsTab(s, d)
 {
   // language
   addLanguages();

diff --git a/src/settingsdialoggeneral.h b/src/settingsdialoggeneral.h
@@ -8,8 +8,7 @@
 class GeneralSettingsTab : public SettingsTab
 {
 public:
-  GeneralSettingsTab(Settings& settings, PluginContainer* pluginContainer,
-                     SettingsDialog& dialog);
+  GeneralSettingsTab(Settings& settings, SettingsDialog& dialog);
 
   void update();
 
@@ -21,9 +20,6 @@ class GeneralSettingsTab : public SettingsTab
 
   void onEditCategories();
   void onResetDialogs();
-
-private:
-  PluginContainer* m_PluginContainer;
 };
 
 #endif  // SETTINGSDIALOGGENERAL_H