Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isDummy to IPluginList #137

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Add isDummy to IPluginList #137

merged 2 commits into from
Oct 28, 2023

Conversation

Silarn
Copy link
Member

@Silarn Silarn commented Oct 17, 2023

@Silarn Silarn requested review from Holt59 and Al12rs October 17, 2023 07:08
@Holt59
Copy link
Member

Holt59 commented Oct 17, 2023

I don't really like the name isDummy, it does not carry the goal of the function... Why not simply hasNoRecords? Or maybe isPlaceholder?

@Silarn
Copy link
Member Author

Silarn commented Oct 17, 2023

Well the term 'dummy plugin' has been in use for quite a while, and that base isDummy function of esptk was something I'm pretty sure Tannin wrote.

But I do understand where you're coming from.

@Silarn Silarn merged commit 2a5fbc9 into master Oct 28, 2023
3 checks passed
@Silarn Silarn deleted the plugin_updates branch October 28, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holt59 Holt59 Holt59 approved these changes

@Al12rs Al12rs Awaiting requested review from Al12rs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Silarn @Holt59