Skip to content

Commit

Permalink
Cleaning for C++20/23.
Browse files Browse the repository at this point in the history
  • Loading branch information
Holt59 committed Jun 29, 2024
1 parent fa232b1 commit 694a9ba
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions src/extension.h
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,16 @@ class QDLLEXPORT IExtension
//
const auto& requirements() const { return m_Requirements; }

public:
virtual ~IExtension() {}
IExtension& operator=(const IExtension&) = delete;

protected:
IExtension(std::filesystem::path path, ExtensionMetaData metadata);

public:
IExtension(const IExtension&) = default;

private:
std::filesystem::path m_Path;
ExtensionMetaData m_MetaData;
Expand Down
3 changes: 2 additions & 1 deletion src/requirements.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ExtensionRequirement::ExtensionRequirement(

ExtensionRequirement::~ExtensionRequirement() = default;

bool ExtensionRequirement::check(IOrganizer* organizer) const
bool ExtensionRequirement::check([[maybe_unused]] IOrganizer* organizer) const
{
return true;
}
Expand All @@ -45,6 +45,7 @@ ExtensionRequirementFactory::parseRequirements(const ExtensionMetaData& metadata

std::vector<ExtensionRequirement> requirements;
for (const auto& json_requirement : json_requirements.toArray()) {
// TODO
}

return requirements;
Expand Down

0 comments on commit 694a9ba

Please sign in to comment.