Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onNextRefresh() and 2nd onAboutToRun bindings. #113

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

Holt59
Copy link
Member

@Holt59 Holt59 commented Sep 26, 2023

@Holt59 Holt59 changed the title Add onNextRefresh() and 2nd onAboutToRun bindings. WIP: Add onNextRefresh() and 2nd onAboutToRun bindings. Sep 26, 2023
@Holt59 Holt59 changed the title WIP: Add onNextRefresh() and 2nd onAboutToRun bindings. Add onNextRefresh() and 2nd onAboutToRun bindings. Sep 27, 2023
@Holt59 Holt59 requested review from Silarn and Al12rs September 27, 2023 18:23
@Al12rs
Copy link
Member

Al12rs commented Sep 27, 2023

Tests need a look at

Copy link
Member

@Silarn Silarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the failure is due to merge dependencies in UIBase.

@Holt59
Copy link
Member Author

Holt59 commented Sep 28, 2023

I'm guessing the failure is due to merge dependencies in UIBase.

The build is passing but the tests are failing (the tests that calls mobase from Python). They were already failing before, I tried fixing them but I could not.

A possible cause is the use of PyQt 6.5.3 with Qt 6.5.0 but I'm not sure because the error I get locally is a mixin between Qt 6.5.0 and Qt 6.5.1.

@Holt59 Holt59 merged commit c6c7e5e into master Sep 29, 2023
2 of 3 checks passed
@Holt59 Holt59 deleted the dev/refresh-callback branch August 9, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants