Always compress baFO4dds and baSFdds archives and use completeBaseName for created archives. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My understanding is that Morrowind BSAs are more different than just being an uncompressed version of what Oblivion to Skyrim use. Have you actually tried one of these BSAs in the original engine? (If you try in OpenMW, that won't tell you anything as it supports every BSA format and non-texture BA2s.) |
|
I did not own Morrowind at the time, but it appears that a functional and identical archive is created regardless of whether set_compressed is passed true or false. I can probably revert the related changes tomorrow. |
Liderate
force-pushed
the
compression_fix
branch
from
65a7124 to
207a3f0
Compare
Liderate
changed the title
|
Apologies for taking a while. I removed the Morrowind related changes and added a fix for an oversight I made in a previous pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Texture type archives for Fallout 4 and Starfield must always be compressed or the game will crash or load infinitely. Morrowind archives must not be compressed. This is information from the BSArchPro tool. I am not sure if having a dedicated MorrowindArchiveBuilder is the best way forward, but it was simple.