Updates for Python 3.11 compatibility #113
Conversation
|
Is this still needed? |
|
I think so, at least this all seems to be fixed for updates to pyqt6 and the differences in the pyi files as well as the necessary dependency version update for 3.11. |
| @@ -33,7 +33,7 @@ def allFiles(self) -> list[str]: | |||
|
|
|||
|
|
|||
| class BasicGameSaveGameInfoWidget(mobase.ISaveGameInfoWidget): | |||
| def __init__(self, parent: QWidget, get_preview: Callable[[Path], Path | None]): | |||
| def __init__(self, parent: QWidget, get_preview: Optional[Callable[[Path], Optional[QPixmap | Path | str]]]): | |||
There was a problem hiding this comment.
Optional should not be used anymore, you can use | None when needed. I don't think making get_preview optional is needed, simply default it to a lambda p: None. I thought this was already done in an existing PR 🤔
| @@ -89,9 +89,9 @@ def setSave(self, save: mobase.ISaveGame): | |||
|
|
|||
|
|
|||
| class BasicGameSaveGameInfo(mobase.SaveGameInfo): | |||
| def __init__(self, get_preview: Callable[[Path], Path | None] | None = None): | |||
| def __init__(self, get_preview: Optional[Callable[[Path], Optional[QPixmap | Path | str]]] = None): | |||
There was a problem hiding this comment.
Same comment as above for Optional.
| super().__init__() | ||
| self._get_preview = get_preview | ||
| self._get_preview: Optional[Callable[[Path], Optional[QPixmap | Path | str]]] = get_preview |
There was a problem hiding this comment.
No need to type here since get_preview (the parameter) is typed.
|
Also, CI will probably fail for |
|
I made the changes because my IDE was complaining that None was not supposed to be valid. I'll have to do this in a few hours. |
I don't know what IDE you're using, but it's probably using a Python version lower than 3.10. |
Some of this may also just be general cleanup for recent changes