-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata to BasicGameSaveGameInfo(Widget) #109
Add metadata to BasicGameSaveGameInfo(Widget) #109
Conversation
Sorry for the delay, could you try rebasing/merging against latest master so that these change can be merged? If you don't have time, I can have a look at it myself. |
I can probably get to it tomorrow, have to check python 11 changes (my local poetry will be conflicting, too). From a quick search that would still be only: |
bc3128d
to
3df1550
Compare
Rebase done. No problems besides the ugly |
Thanks for the update! @Silarn Added save metadata preview to Blade & Sorcery recently, could you see if these could be moved to your new generic metadata system? |
Obviously this would need to be merged in first but yeah, I think you can just migrate the BaSSaveGameWidget code to a new 'bas_parse_metadata' function passed into the updated BasicSaveGameInfo. |
be8df3c
to
b347ab3
Compare
I added an option to set the (max) widget width and refactored blade & sorcery, should work. Want me to cleanup the history before merge? |
ecacbdf
to
cc95749
Compare
Ok, widget size, default parameter handling and an easier option to set a custom widget added: Widget tested with Cyberpunk. |
Unfortunately I was having a requester on Discord test my initial changes. But I might be able to get a hold of him. |
3c8e908
to
403558f
Compare
Commits cleaned up. Ready to merge (Blade & Sorcery tested, too). |
403558f
to
734acdb
Compare
I removed Cyberpunk |
shows file date by default (for all games with `SaveGameInfo` feature)
734acdb
to
f36e386
Compare
Rebased on master, with PR #122, rdy for merge. |
Adds optional metadata to the
BasicGameSaveGameInfoWidget
, similar to TES / Gamebryo games:Example from Cyberpunk 2077, included in #105:
Adds a default file date to all BasicGames, taken from the save game files (
GameSaveExtension
etc.)