Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trosski's Starfield theme #125

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Add Trosski's Starfield theme #125

merged 3 commits into from
Nov 14, 2023

Conversation

Silarn
Copy link
Member

@Silarn Silarn commented Nov 8, 2023

No description provided.

@Silarn Silarn requested a review from Holt59 November 8, 2023 05:49
@Holt59
Copy link
Member

Holt59 commented Nov 8, 2023

I've not tested the other third-party themes but are these okay with Qt 6.5? Because while it's nice to have themes, if older ones are not maintained that's not really sustainable.

@Silarn
Copy link
Member Author

Silarn commented Nov 8, 2023

I mean this one is brand new and he's active in discord. The only real issue I've seen with themes apart from Qt bugs is the relatively harmless iconSize change.

@Silarn Silarn marked this pull request as draft November 9, 2023 20:14
@Silarn
Copy link
Member Author

Silarn commented Nov 9, 2023

Thought I had this set up in my working build but it turns out the archive name was changed in the 1.1 release and it requires another change. I'll push that later.

@Silarn Silarn marked this pull request as ready for review November 14, 2023 20:17
@Silarn Silarn merged commit a835d16 into master Nov 14, 2023
@Silarn Silarn deleted the trosski_starfield branch November 14, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants