Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning and improvements #122

Merged
merged 5 commits into from
Sep 24, 2023
Merged

Cleaning and improvements #122

merged 5 commits into from
Sep 24, 2023

Conversation

Holt59
Copy link
Member

@Holt59 Holt59 commented Sep 24, 2023

  • Remove NCC patch since NCC is not build anymore.
  • Exclude a string from the NMake outputs - This was causing mob to display stderr at the end for no reason.
  • Fetch PyQt6 sources from riverbank when using a dev build.
  • Allow bootstrap.ps1 to build Debug and RelWithDebInfo if needed.
  • Avoid overriding task-specific configuration with pattern configuration (see below).

Before, if you add the following INI:

[installer_wizard:task]
enabled = false

And you would run mob build installer_*, the installer_wizard would be built.

In my opinion, this is annoying, because a pattern-configuration (installer_*) should not override a task-specific configuration. The change make it so you can only override an INI setting from the command line if the pattern matches exactaly, e.g.

# no pattern -> installer_wizard will not be built
mob build

# exact name -> installer_wizard will be built
mob build installer_wizard
mob build installer_wizard installer_fomod

# pattern -> installer_wizard will not be built
mob build installer_*
mob build installer_wi*

@Holt59 Holt59 requested review from Silarn and Al12rs September 24, 2023 08:12
@Al12rs
Copy link
Member

Al12rs commented Sep 24, 2023

Looks good to me

@Holt59 Holt59 merged commit b2eae1b into master Sep 24, 2023
@Silarn Silarn deleted the dev/clean-and-fix branch December 16, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants