Open
Conversation
Contributor
Bansenauer-Cascadia
left a comment
Bansenauer-Cascadia
left a comment
There was a problem hiding this comment.
The BeerExpert model still needs some additional refactoring work to make it complete
|
|
||
|
|
||
| String getRecommendation(String color) { | ||
| static String getRecommendation(String color) { |
Contributor
There was a problem hiding this comment.
Instead of making this static, refactor the method to use a new "mColor" instance variable
| String beerType = String.valueOf(colorSpinnerView.getSelectedItem()); | ||
|
|
||
| //TODO: WRITE code to get recommendations from the BeerExpert class | ||
| String beerBrand = BeerExpert.getRecommendation(beerType); |
Contributor
There was a problem hiding this comment.
When you use the model, be sure to use the reference variable, rather than the class name, e.g., use expert.getRecommendation() instead of BeerExpert.getRecommendation()
|
|
||
| //TODO: MODIFY code to display the brands instead of the beerType using the BeerExpert class | ||
| brandsListView.setText(beerType); | ||
| brandsListView.setText(beerBrand); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.