updated dashboard#192
Merged
Merged
Conversation
zakkiyyat
reviewed
Jun 22, 2026
Comment on lines
+12
to
+20
| useEffect(() => { | ||
| if (!user) { | ||
| router.replace('/login'); | ||
| } | ||
| }, [user, router]); | ||
|
|
||
| if (!user) return null; | ||
|
|
||
| return ( |
Contributor
There was a problem hiding this comment.
Auth guard destructs user from useAuth() but ignores isLoading. On first render user is null (localStorage hasn't been read yet), so the guard fires router.replace('/login') immediately — an authenticated user gets bounced to login and back in a flash. The fix is to wait until isLoading === false before evaluating user.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #188