Modernize codebase: fix "cannot read properties of undefined" error, update dependencies, enable strict mode#5
Open
dizzlkheinz wants to merge 2 commits into
Open
Conversation
- Fix async checkFile bug causing "Cannot read properties of undefined" error - Update all dependencies to latest stable versions (TS 5.6, esbuild 0.25, ESLint v8) - Enable TypeScript strict mode with all type-checking options - Add stricter ESLint rules with type-aware linting - Fix 35+ code quality issues from stricter checks - Add CLAUDE.md documentation for future development - Resolve all 7 security vulnerabilities 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Hello, thanks for the pr! After a quick inspection is seems that the code is ok so no problem there. If you prefer, please add a section to the readme file noting the usage of claude and listing the feature and fixed it has worked on. |
dizzlkheinz
added a commit
to dizzlkheinz/vault2book-plugin
that referenced
this pull request
Nov 8, 2025
Per maintainer feedback on PR Mitra98t#5, remove dedicated CLAUDE.md file and add a Development section to README documenting Claude Code's contributions: - Bug fixes (async checkFile error) - Code quality improvements (strict mode, ESLint rules) - Dependency updates and security fixes - Build commands reference 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Okay; I gave claude your comment and it did it's thing. I hope that it's helpful. |
Per maintainer feedback on PR Mitra98t#5, remove dedicated CLAUDE.md file and add a Development section to README documenting Claude Code's contributions: - Bug fixes (async checkFile error) - Code quality improvements (strict mode, ESLint rules) - Dependency updates and security fixes - Build commands reference 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin wasn't working for me so I asked claude to vibe code a fix and in general update the dependencies and it did and it now works for me so I thought I would submit it back to you.
🤖 Generated with Claude Code