TCP socket usage + documentation added #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 |
Contributor
|
I don't like that we are introducing a breaking change. I think we should probably bump the version for this or set this up so its not the default. |
docs/source/getstart.rst
Outdated
Contributor
There was a problem hiding this comment.
should this be auth_tcp = "none" like in the what gets set on the nova computes?
Contributor
Author
There was a problem hiding this comment.
Yeah, you're right, my bad. fixed.
Contributor
Author
|
About braking change... It's the right way I this to do not break anything within the major version. So we can merge it into new branch called 3.x. And in 2-3 months merge it into master with bumped version to 3.0. |
Contributor
|
we should follow Openstack branching methods. we should create a 2.0 OR stable branch and retain changes like this on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #21 + doc + rebase.