Skip to content

Draft: Use dependency attributes instead of version markers for remapped dependencies #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: FG_6.0
Choose a base branch
from

Conversation

KitsuneAlex
Copy link
Contributor

This adds two new overloads to the deobf function in DependencyManagementExtension which allows clean integration with Gradle version catalogs, especially useful when working with the Kotlin DSL.

@KitsuneAlex KitsuneAlex changed the title Add two new overloads for fg.deobf() to support version catalogs and dependency variants Draft: Use dependency attributes instead of version markers for remapped dependencies Sep 15, 2024
@KitsuneAlex KitsuneAlex marked this pull request as draft September 15, 2024 00:26
@Jonathing
Copy link
Member

I noticed that this PR was still open, so I'll quickly give my two cents on this.

If we wanted to merge this, it would probably be for a ForgeGradle 6.2, since changes to how dependencies are mapped will likely break plugins that hook into ForgeGradle. While that isn't inherently bad, ForgeGradle is historically one of those plugins that have always been used with other plugins that hook into it. So, I don't see myself merging this.

I'm taking a completely different approach to deobfuscated dependencies in ForgeGradle 7.0 that doesn't use this old system at all. If I think a ForgeGradle 6.2 is warranted, then I'll consider merging this in and working with it as such. For now though, consider this as stale. I'll close when ForgeGradle 7.0 releases which will have better, proper support for deobfuscating external module dependencies in a non-intrusive manner.

@Jonathing Jonathing self-assigned this May 24, 2025
@Jonathing Jonathing added planned Feature or enhancement is planned next breaking version Feature or enhancement is targeted towards the next breaking version enhancement Enhances an existing feature in the codebase FG6 This request is for FG 6 labels May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances an existing feature in the codebase FG6 This request is for FG 6 next breaking version Feature or enhancement is targeted towards the next breaking version planned Feature or enhancement is planned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants