Add pattern matching instanceof #112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't a better solution be to rebase against upstream which in theory has had this support since early december? MinecraftForge/FernFlower@91cf425 |
|
Closing in favor of #114, thanks though! |
|
This appears to be a draft because it supposedly has improvements over upstream which need to be rebased & reevaluated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
22w11a diff
1.18.2-rc1 diff
Fixes the compile error where a generic is assigned into a variable with the type
StringReaderhere in 22w11a.Doesn't currently support the way ecj compiles pattern matching instanceof which does the cast twice and check if the casts are the same as well as registering the generated variable in the local variable table.