Skip to content

extract data from mat file, reproject the facies and plot the virtual cores#4

Open
xyl96 wants to merge 5 commits intomainfrom
issue_3_strata_comparison
Open

extract data from mat file, reproject the facies and plot the virtual cores#4
xyl96 wants to merge 5 commits intomainfrom
issue_3_strata_comparison

Conversation

@xyl96
Copy link
Contributor

@xyl96 xyl96 commented Dec 16, 2025

Extracting the data from MAT file from STACKER, reproject the facies and plotting.

@xyl96
Copy link
Contributor Author

xyl96 commented Dec 16, 2025

Here is some discrepancies:
The figure I have obtained is listed below.
STACKER_cores
While the three cores (mid three) directly from STACKER is listed below here:
cross_sinSL
I do not why this is happenning.

@xyl96
Copy link
Contributor Author

xyl96 commented Dec 17, 2025

Here is some discrepancies: The figure I have obtained is listed below. STACKER_cores While the three cores (mid three) directly from STACKER is listed below here: cross_sinSL I do not why this is happenning.

I did something erong in the code! I will check it today!

@xyl96
Copy link
Contributor Author

xyl96 commented Dec 17, 2025

The plotting issue has been solved

@EmiliaJarochowska
Copy link
Member

As a general feedback on this PR: it is not clear what the problem is. From the issue description #3 it seems to me that plotting the columns is the problem, but from the PR title it seems that extracting data from mat files is the problem. Which one is it?

If it is the plotting that is needed, is there anything about these cores that requires writing completely new code for plotting columns? There are a bunch of packages for doing that, including our home one https://mindthegap-erc.github.io/stratcols/ by @NiklasHohmann

So my general feedback:

  1. Specify what is the feature you are developing (extracting, plotting, comparing?) and make sure the PR matches the problem declared
  2. The thicknesses of the cores don't match the figure from Stacker (e.g. there is no core with a thickness of 0.6 m)
  3. Store data in data not in src
  4. Would using stratcols resolve the problem (but see 1 - what is the problem exactly?)

facies_code = unique(facies)

# remap facies
new_facies_map = Dict(0.0=>100, 1.0=>101, 2.0=>102, 3.0=>103, 4.0=>103, 5.0=>105)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you first remap facies to new integer codes and then these codes again to strings? What are 100, 101 etc needed for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are DRTs. Well, I just think it's easier for me to get head around. The strings only existed when producing legends.

for idx in eachindex(core_layers_norm)[2:end]
top = core_layers_norm[idx]
bottom = core_layers_norm[idx-1]
if core_facies[idx] != 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why assign properties to hiatus (color and transparency) if it's never plotted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it specifically to check whether the codes are following what I want - it happens when I was writing the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o empty file, why are you here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's for comparison in the next step: this file would plot the digitized data from the cores.

@xyl96 xyl96 changed the title extract data from mat file extract data from mat file, reproject the facies and plot the virtual cores Dec 18, 2025
@xyl96
Copy link
Contributor Author

xyl96 commented Dec 18, 2025

As a general feedback on this PR: it is not clear what the problem is. From the issue description #3 it seems to me that plotting the columns is the problem, but from the PR title it seems that extracting data from mat files is the problem. Which one is it?

If it is the plotting that is needed, is there anything about these cores that requires writing completely new code for plotting columns? There are a bunch of packages for doing that, including our home one https://mindthegap-erc.github.io/stratcols/ by @NiklasHohmann

So my general feedback:

  1. Specify what is the feature you are developing (extracting, plotting, comparing?) and make sure the PR matches the problem declared
  2. The thicknesses of the cores don't match the figure from Stacker (e.g. there is no core with a thickness of 0.6 m)
  3. Store data in data not in src
  4. Would using stratcols resolve the problem (but see 1 - what is the problem exactly?)

reply:

  1. The initiative and aims have been updated. the aim is 3-fold, including extracting, reprojection of facies and plotting. Comparison is on the way not done yet. Should be in another issue. So it is not pure 'plotting'.
  2. That's the thing I am thinking. I checked the original STACKER code yesterday and I think I followed the way he did.
  3. no data was stored in src - they were stored in results. Except the results from STACKER. What should I do with the MAT file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants